Skip to content

fix(lsp monaco): avoid runtime and bundling errors on Monaco and LSP - #2830

Merged
Danielku15 merged 1 commit into
developfrom
feature/fix-monaco
Aug 9, 2026
Merged

fix(lsp monaco): avoid runtime and bundling errors on Monaco and LSP#2830
Danielku15 merged 1 commit into
developfrom
feature/fix-monaco

Conversation

@Danielku15

Copy link
Copy Markdown
Member

Issues

Fixes #2829

Proposed changes

Refactoring the LSP and Monaco imports/exports to have separate paths for Browser and Node based usage. Root cause is that vscode-languageserver reorganized their package exports to have clear node and browser entry points.

We now follow the same pattern.

Checklist

  • I consent that this change becomes part of alphaTab under its current or any future open source license
  • This PR is linked to an accepted issue (see above)
  • Changes are implemented
  • New tests were added
  • I have read AGENTS.md if an AI helped draft any part of this PR

AI authorship disclosure

  • No AI agent authored any part of this PR (description, code, tests, or commit messages)
  • An AI agent contributed to this PR. The AI-authored disclosure block
    (alphatab-ai-authored-v1) is present at the top of this body, and I have
    personally reviewed every change and can explain each one

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15
Danielku15 merged commit 5faabb2 into develop Aug 9, 2026
6 checks passed
@Danielku15
Danielku15 deleted the feature/fix-monaco branch August 9, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Monaco editor playground broken after upgrades

1 participant