Improved error handling for WXR file parsing#496
Open
girishpanchal30 wants to merge 2 commits into
Open
Conversation
girishpanchal30
added
the
pr-checklist-skip
pirate-bot
added
the
pr-checklist-complete
Collaborator
There was a problem hiding this comment.
Pull request overview
This PR updates the WXR SimpleXML parser to avoid PHP 8+ fatal errors when the WXR source is missing or empty by validating the file and its contents before calling DOMDocument::loadXML().
Changes:
- Add filesystem existence check for the WXR file before attempting to parse it.
- Add guard against empty/unreadable file contents to prevent
loadXML( '' )fatal errors.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+26
to
+30
| if ( ! $wp_filesystem->exists( $file ) ) { | ||
| return new WP_Error( 'SimpleXML_parse_error', 'The specified WXR file does not exist' ); | ||
| } | ||
|
|
||
| $contents = $wp_filesystem->get_contents( $file ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checked that the WXR file exists and is valid. If not, then return an error message instead of proceeding with the import to prevent a fatal error.
Check before Pull Request is ready:
Closes #491