fix(cli): declare release and DOM test dependencies - #1190
Open
c8dhjp4tyv-bit wants to merge 1 commit into
Open
Conversation
c8dhjp4tyv-bit
added a commit
to c8dhjp4tyv-bit/freebuff
that referenced
this pull request
Sep 1, 2026
github-actions
Bot
force-pushed
the
recreate/1109-cli-typecheck-dependencies
branch
from
September 1, 2026 07:50
a01a061 to
5946830
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tar, which the release launcher and wrapper safety tests import in the private CLI workspace@types/react-dom, which the CLI's server-rendering tests require for typecheckingbun.lockwith the minimal dependency graph changes while preserving the rewritten upstream lockfiletarintentionally remains a CLI workspace devDependency: the actual published wrappers (cli/release,cli/release-staging, andfreebuff/cli/release) each already declaretarin their own runtimedependencies.Validation
Prior validation before the history rewrite:
tar.candrenderToStaticMarkupresolvetar-fs/chownr@1.1.4,lru-cache/yallist@4.0.0) rather than upgrading them transitivelygit diff --checkpassesFor this recreated branch, Bun 1.3.14 regenerated the lockfile from the current rewritten
main. The resulting diff remains exactly 2 files with the same18+/2-lockfile and3+/1-package-manifest scope as the final old branch.