fix(common): honor DeepSeek Beijing weekend boundaries - #1187
Open
c8dhjp4tyv-bit wants to merge 1 commit into
Open
fix(common): honor DeepSeek Beijing weekend boundaries#1187c8dhjp4tyv-bit wants to merge 1 commit into
c8dhjp4tyv-bit wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1090
Summary
Why
The existing weekend tests used instants where UTC and Beijing were already on the same weekend day, so removing the
+8hour conversion left the suite green. The new boundary cases pin Friday 16:00Z and Sunday 16:00Z, where the calendars diverge.Verification
Prior validation before the history rewrite:
bun test common/src/__tests__/freebuff-peak-hours.test.ts— 26 passedbun run --cwd common typecheck— passedgit diff --check— passedThe full
commontest command cannot pass in this public checkout because several existing tests reference private/web files absent from the mirror; the changed test file passes independently.