Skip to content

fix(cli): survive unavailable chat log directory - #1186

Open
c8dhjp4tyv-bit wants to merge 1 commit into
CodebuffAI:mainfrom
c8dhjp4tyv-bit:recreate/1099-cli-logger-startup-resilience
Open

fix(cli): survive unavailable chat log directory#1186
c8dhjp4tyv-bit wants to merge 1 commit into
CodebuffAI:mainfrom
c8dhjp4tyv-bit:recreate/1099-cli-logger-startup-resilience

Conversation

@c8dhjp4tyv-bit

Copy link
Copy Markdown

Recreated on the rewritten main after #1099 was auto-closed during repository maintenance. This carries the same reviewed change set on the new history.

Summary

  • prevent logger initialization from crashing the CLI when the current chat directory cannot be created
  • keep file logging best-effort while preserving the existing development and production destinations
  • add regression coverage for both destinations and the unavailable-chat-directory path

Fixes #783

Validation

Prior validation before the history rewrite:

  • logger.test.ts: 3 passed
  • common typecheck: passed
  • SDK typecheck: passed
  • git diff --check: passed
  • full CLI test command: 2,111 passed; existing checkout/environment failures remain in unrelated Infisical, read-only config, and missing release-dependency tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't launch (ENOENT)

1 participant