feat: add code-review-checklist skill for code review guidance - #1172
Open
AbhijitK20 wants to merge 1 commit into
Open
feat: add code-review-checklist skill for code review guidance#1172AbhijitK20 wants to merge 1 commit into
AbhijitK20 wants to merge 1 commit into
Conversation
Adds a structured review checklist specific to the freebuff codebase. Covers correctness, TypeScript conventions, security, testing, freebuff-specific invariants, and key files to watch. This is a single skill (not the three-skill bundle from the original PR CodebuffAI#903) and references actual repo conventions from AGENTS.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a single
code-review-checklistskill to the initial agents directory. This is a recreation of #903 (auto-closed by history rewrite), addressing the feedback from that PR.What changed from #903
code-review-checklist(the original bundled 3 unrelated skills)AGENTS.md, known import cycles, free session invariants, and key files to watchproject-files → auth → logger → project-files)" and "bun:test, not jest"Skill content
The checklist covers:
IS_FREEBUFFguards, session state transitions, one-instance-per-accountauth.ts,freebuff-session-store.ts,use-freebuff-session.ts, etc.Location
common/src/templates/initial-agents-dir/skills/code-review-checklist/SKILL.mdFollows the existing
example-skillconvention with YAML frontmatter matching theSKILL.mdschema documented in the skills README.Links to original PR: #903