Skip to content

Fix safeReplace to replace all matches#762

Open
hiSandog wants to merge 1 commit into
CodebuffAI:mainfrom
hiSandog:fix/safe-replace-all-20260527
Open

Fix safeReplace to replace all matches#762
hiSandog wants to merge 1 commit into
CodebuffAI:mainfrom
hiSandog:fix/safe-replace-all-20260527

Conversation

@hiSandog
Copy link
Copy Markdown
Contributor

Summary

  • update safeReplace to replace every matching occurrence instead of only the first
  • add coverage for replacing multiple matches and keeping dollar signs literal in replacement text

Validation

  • env PATH=/Users/sandog/.real/.bin:/usr/local/bin:/opt/homebrew/bin:/usr/bin:/bin:/usr/sbin:/sbin /Users/sandog/.real/.bin/bun test common/src/util/tests/string.test.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant