London | 26-ITP-May | Chinwe Chukwuma | Sprint 3 | Practice TDD - #1576
Open
ChinweP wants to merge 4 commits into
Open
London | 26-ITP-May | Chinwe Chukwuma | Sprint 3 | Practice TDD#1576ChinweP wants to merge 4 commits into
ChinweP wants to merge 4 commits into
Conversation
ChinweP
added
📅 Sprint 3
cjyuan
reviewed
Jul 28, 2026
| }); | ||
|
|
||
| // Case 4: All other numbers → 'th' | ||
| test("should append 'th' for all other numbers", () => { |
Contributor
There was a problem hiding this comment.
When a test fails with the message "... all other numbers", it may be unclear what "other numbers" actually refers to.
Can you revise the test description to make it more informative?
Author
There was a problem hiding this comment.
Lesson learnt. to try not to be vague with test description. I have revised the test description to make it more informative. Thank you @cjyuan.
cjyuan
added
Reviewed
ChinweP
added
the
Needs Review
Contributor
|
Change look good. Well done. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Coursework/practice-tdd completed following ReadMe instructions