Skip to content

Birmingham | may-2026-itp | Alexandra Clincu | Sprint 2 | Wireframe to Web Code#1323

Open
AlexandraClincu28 wants to merge 1 commit into
CodeYourFuture:mainfrom
AlexandraClincu28:feature/wireframe
Open

Birmingham | may-2026-itp | Alexandra Clincu | Sprint 2 | Wireframe to Web Code#1323
AlexandraClincu28 wants to merge 1 commit into
CodeYourFuture:mainfrom
AlexandraClincu28:feature/wireframe

Conversation

@AlexandraClincu28
Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • [x ] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [x ] My changes meet the requirements of the task
  • [x ] I have tested my changes
  • [x ] My changes follow the style guide

Changelist

Created a Webpage based on the provided wireframe, styled the page using CSS and matched the layout to the wireframe design.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 20, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 5871fbb
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a0df240de32290008ba6202
😎 Deploy Preview https://deploy-preview-1323--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@AlexandraClincu28 AlexandraClincu28 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 20, 2026
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 27, 2026
Copy link
Copy Markdown

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this task, there are a few changes you need to make

Comment thread Wireframe/index.html
<a href="">Read more</a>
</article>
<article>
<img src="placeholder.svg" alt="" />
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some unique images for each article?

Comment thread Wireframe/index.html
<footer>
<p>
This is the default, provided code and no changes have been made yet.
Created by Alexandra Clincu.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the page is narrow, do you see what happens to the footer as you scroll? Is there a way to ensure it remains fully readable?

Comment thread Wireframe/index.html
<p>
A wireframe is a visual plan used to organise the structure of a website.
</p>
<a href="">Read more</a>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some links to relevant pages here?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants