Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
BrianY315
force-pushed
the
feature/sprint-3-quote-generator
branch
from
November 16, 2026 15:02
bfdfbd8 to
bde613f
Compare
Comment on lines
+23
to
+25
| await new Promise((resolve) => { | ||
| page.window.document.addEventListener("load", resolve); | ||
| }); |
There was a problem hiding this comment.
What has already happened by the time JSDOM.fromFile resolves, and will this listener still see that load event?
To "like" or "dislike" this comment, please follow this link
Author
There was a problem hiding this comment.
JSDOM.fromFile() resolves after reading the HTML and creating the DOM, not after the page’s load event. Here, readyState was still loading, so the listener caught it. I’ve made the wait robust by checking readyState first and otherwise listening once for load on window; the tests pass.
|
The CYF AI review has left comments. It will only review a PR one time. When you have addressed these comments, please request review again and a volunteer will take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1096
Changelist
This PR completes the quote generator: it displays a random quote and author on page load, and the New Quote button shows another without repeating the current quote. It also updates the page title and adds a regression test for repeated random selections.