Select tag helper: retarget net10.0, drop the enum wrapper class, fix the Bootstrap select classes - #2182
Open
vladimir-pecanac-main wants to merge 3 commits into
Conversation
…tstrap select classes
- SelectTagHelper.csproj and Tests.csproj: net6.0 -> net10.0, nullable enabled
and view-model properties annotated.
- Test packages lifted: Microsoft.NET.Test.Sdk 18.9.0, MSTest.TestAdapter and
MSTest.TestFramework 4.4.0, coverlet.collector 10.0.1.
- Program.cs rewritten as top-level statements.
- The Enumerations wrapper class around the Department enum is gone; Department
now lives directly in SelectTagHelper.Enums, so the views call
Html.GetEnumSelectList<Department>() and match the article.
- StaticRepository and HomeController lifted to collection expressions and
target-typed new(). The article keeps the explicit new SelectListItem { ... }
form in its first example on purpose: that snippet exists to show the reader
what a SelectListItem is.
- Every select carried class="form-select-sm" with no form-select. Bootstrap
5.1.0 is bundled in wwwroot/lib, where the -sm modifier styles nothing on its
own, so the pair is now form-select form-select-sm.
- New Placeholder action and view showing a disabled first item with an empty
Value as a placeholder row, plus a test asserting it is present, disabled and
selected. 12 tests pass on net10.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refresh of
aspnetcore-features/SelectTagHelperSolutionalongside a rewrite of the article it backs (https://code-maze.com/select-tag-helper-aspnetcore/).Retarget and packages
SelectTagHelper.csprojandTests.csproj:net6.0->net10.0,<Nullable>enable</Nullable>added to both, view-model properties annotated.Microsoft.NET.Test.Sdk17.1.0 -> 18.9.0,MSTest.TestAdapterandMSTest.TestFramework2.2.8 -> 4.4.0,coverlet.collector3.1.2 -> 10.0.1. Versions resolved from NuGet today.Idiom lifts
Program.csrewritten as top-level statements. The explicitProgramclass andMainwrapper aroundWebApplication.CreateBuildermade the sample read as if it predated .NET 6. The test project referencesHomeControllerdirectly and does not useWebApplicationFactory<Program>, so nothing depended on the type.Enumerationswrapper class around theDepartmentenum is deleted.Departmentnow lives directly inSelectTagHelper.Enums, so the views callHtml.GetEnumSelectList<Department>()instead ofHtml.GetEnumSelectList<Enumerations.Department>(). The article always showed the un-nested form; the repo is the side that was out of step.StaticRepository.csandHomeController.cslifted to collection expressions and target-typednew(). This shrinks the code rather than growing it.new SelectListItem { ... }form in its first example: that snippet exists to show the reader what aSelectListItemis, so the two sides diverge there on purpose.Bootstrap classes
Every
<select>carriedclass="form-select-sm"with noform-select.wwwroot/lib/bootstrapbundles Bootstrap 5.1.0, where.form-select-smis a size modifier that styles nothing on its own, which is why the screenshots show unstyled native dropdowns. The pair is nowform-select form-select-sm.MultiSelect.cshtmlalready hadform-selectand is unchanged.New placeholder example
A
Placeholderaction and view render a disabled first item with an emptyValueas a placeholder row, so the article's claim aboutSelectListItem.Disabledhas running code behind it. Note thatSelected = trueon such an item only survives when the bound property's value is already empty: withasp-for, the tag helper computes selection from the model expression and drops the flag when the values do not match.Build and tests
dotnet build -c Release: succeeded, 0 warnings, 0 errors on SDK 10.0.302.dotnet test -c Release: Passed - Failed: 0, Passed: 12, Skipped: 0, Total: 12. The 11 existing tests are unchanged and green; the twelfth is the new placeholder assertion.