[tomtourwe]

Replaces type names written out in full in the code by their simple name plus an import, for example
java.util.List<String> list = new java.util.ArrayList<>() becomes List<String> list = new ArrayList<>()
with import java.util.ArrayList; and import java.util.List;. The change is mechanical, made with an automated
import refactoring.

The two commits

1. Imports cleaned up (cc1694b6c): unused imports are removed, and every import block is sorted in one order.
   No code line changes.
2. Qualified names shortened (9adc92436): a type name written in full becomes its simple name and the import
   is added. A nested type keeps its enclosing type (java.util.Map.Entry becomes Map.Entry, importing
   java.util.Map); a static member keeps its class (java.util.Collections.emptyList() becomes
   Collections.emptyList()); no static import is added. Comments, javadoc and string literals are left as they are.

A name stays qualified where its simple name would mean another type in that file: another type of that simple
name is imported, declared or written in the file, or two on-demand imports would both provide it.

Verification

• Every main, test and test-fixtures Java source set compiles.
• ./gradlew test passes, with no failures.

Classes that keep qualified names

These classes in maddi-aapi-archive declare stand-ins for types of two libraries that share simple names (for
example java.util.List and io.vavr.collection.List), so one of the two stays qualified:

• ComGoogleCommonCollect.java, line 302 writes java.util.Optional in full
• IoVavr.java, line 2887 writes io.vavr.collection.Map in full
• IoVavrCollection.java, line 72 writes java.util.List in full
• IoVavrConcurrent.java, line 32 writes io.vavr.concurrent.Future in full

These other classes keep a qualified name because its simple name already means another type there (for example
org.slf4j.Logger beside an import of ch.qos.logback.classic.Logger):

• maddi-callgraph: CommonTest.java, line 49 writes org.slf4j.Logger in full
• maddi-inspection-integration: JavaInspectorImpl.java, line 436 writes java.lang.Runtime in full
• maddi-inspection-integration: CommonTest.java, line 52 writes org.slf4j.Logger in full
• maddi-inspection-integration: CommonTest2.java, line 45 writes org.slf4j.Logger in full
• maddi-inspection-integration: TestCompilationProblem.java, line 38 writes org.slf4j.Logger in full
• maddi-inspection-integration: TestModuleInfo.java, line 54 writes org.slf4j.Logger in full
• maddi-inspection-openjdk: JavaInspectorImpl.java, line 689 writes java.lang.Runtime in full
• maddi-java-openjdk: ClassSymbolScanner.java, line 2645 writes com.sun.tools.javac.util.List in full
• maddi-java-openjdk: ScanCompilationUnits.java, line 269 writes javax.lang.model.element.Element in full
• maddi-java-openjdk: CommonTest.java, line 162 writes java.lang.Runtime in full
• maddi-java-parser: CommonParse.java, line 256 writes org.parsers.java.ast.TypeParameter in full
• maddi-java-parser: ParseBlock.java, line 54 writes io.codelaser.maddi.cst.api.statement.Statement in full
• maddi-java-parser: ParseCompilationUnit.java, line 50 writes io.codelaser.maddi.cst.api.element.CompilationUnit in full
• maddi-java-parser: ParseConstructorCall.java, line 190 writes io.codelaser.maddi.cst.api.expression.ArrayInitializer in full
• maddi-java-parser: ParseExpression.java, line 105 writes org.parsers.java.ast.Expression in full
• maddi-java-parser: ParseHelperImpl.java, line 116 writes io.codelaser.maddi.cst.api.statement.ExplicitConstructorInvocation in full
• maddi-java-parser: ParseLambdaExpression.java, line 114 writes org.parsers.java.ast.Expression in full
• maddi-java-parser: ParseMethodDeclaration.java, line 168 writes io.codelaser.maddi.cst.api.statement.Statement in full
• maddi-java-parser: ParseRecordPattern.java, line 47 writes org.parsers.java.ast.RecordPattern in full
• maddi-java-parser: ParseStatement.java, line 73 writes io.codelaser.maddi.cst.api.statement.Statement in full
• maddi-java-parser: ScanCompilationUnit.java, line 56 writes io.codelaser.maddi.cst.api.element.CompilationUnit in full
• maddi-run-kotlin: TestOneEntryPoint.java, line 66 writes io.codelaser.maddi.run.openjdkmain.Main in full
• maddi-run-main: RunAnalyzer.java, line 112 writes ch.qos.logback.classic.Logger in full

module-info.java, line 14 writes uses io.codelaser.maddi.analysis.api.AnalysisEngine;, which stays as it is.

[github-actions]

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

---

I have read the CLA Document and I hereby sign the CLA

---

Tom Tourwe seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.}

[tomtourwe]

Replaced by #184, the same change made on the current devel (65c45ad).