Repository navigation
Conversation
tomtourwe
force-pushed
the
unused-code/all-60-source-sets
branch
2 times, most recently
from
November 13, 2026 13:23
32667af to
f5479c4
Compare
Removes the declarations that no entry point reaches, as found by CodeLaser's dead-code analysis on hibernate-orm 0347df9 with all 60 source sets of the build parsed (main, test, the JMH benchmarks, the integration tests, the dialect-provider fixtures, jakartaData). Generated sources (antlr, xjc, JMH) are parsed but never edited; code the documentation includes is kept. An enum constant is removed only when no kept constant follows it, so no constant changes its ordinal. 120 types, 1,371 methods and 303 fields, in 1,094 groups that become unused only together; 2,686 declarations, 707 files. Every source set compiles after the removal, `ciCheck releasePrepare -x test` passes, and `test` passes on H2.
tomtourwe
force-pushed
the
unused-code/all-60-source-sets
branch
from
November 13, 2026 15:02
f5479c4 to
f73bd37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal PR on the CodeLaser fork, to run hibernate-orm's CI on the removal. Not for upstream.
Removes the declarations that no entry point reaches, found by CodeLaser's dead-code analysis on hibernate-orm 0347df9 with all 60 source sets of the build parsed (main, test, JMH benchmarks, integration tests, dialect-provider fixtures, jakartaData). Generated sources (antlr, xjc, JMH) are parsed but never edited.
Every source set compiles after the removal (
compileTestJavaplus the 11 other source sets' compile tasks). Locally produced by codelaser-benchmarks bench run20261113-140826-engine-r1-hibernate-orm;ciCheck releasePrepare -x test(CI's initial build, documentation included) passes locally. Code the documentation includes is kept.