fix(nuxt): use a standalone tsconfig for the module build#2060
Merged
Conversation
The tsconfig extended the generated playground tsconfig, which does not exist on a fresh checkout and broke the release build.
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v2.0.0 release workflow failed in
release.sh's full build:packages/nuxt/tsconfig.jsonextended./playground/.nuxt/tsconfig.json, which only exists afternuxi prepare— not on a fresh CI checkout. CI never caught it becausebuild:cidoesn't build the nuxt package.The module now uses a small standalone tsconfig. Verified locally with the generated playground files removed:
nuxt-module-build buildgreen.