fix(deps): repair lint after security overrides#2058
Merged
Conversation
The ajv@6 override broke @eslint/eslintrc (the patched ajv 6.14 drops the missingRefs API), failing every lint run. The override is removed and the ajv alert gets dismissed as dev tooling instead. eslint is updated to 9.39 across packages with two trailing-comma autofixes for its newer rule set.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2058 +/- ##
==========================================
+ Coverage 99.26% 99.35% +0.09%
==========================================
Files 83 83
Lines 3244 3244
Branches 562 562
==========================================
+ Hits 3220 3223 +3
+ Misses 17 15 -2
+ Partials 7 6 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI lint job broke after #2056: the
ajv@6 >= 6.14override collides with@eslint/eslintrc, which still uses ajv's removedmissingRefsAPI — every eslint run died withCannot set properties of undefined (setting 'defaultMeta').ajv@6override removed; the underlying ajv alert gets dismissed instead (eslint-internal schema validation, dev tooling only, no untrusted input)@eslint/plugin-kit >= 0.3.4override)@stylistic/comma-dangleautofixes for the newer rule setAll four packages lint green locally, builds + full suites green.