Repository navigation
Conversation
the search bar logged the whole subject list on every load, and both search bars sorted results by score although fuse was set up without includeScore, so every comparison was Infinity - Infinity. fuse already returns the best matches first, so the sort goes
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Purpose
The home search bar logged the whole subject list to the console on every load. Both search bars also sorted results with
(a.score ?? Infinity) - (b.score ?? Infinity), but Fuse was set up withoutincludeScore, so every comparison wasInfinity - Infinity = NaN.Corresponding issue: closes #547
🖼️ Showcase
No visible change. Fuse already returns results best match first, so the order users see is the same.
🔧 Changes
console.log(initialSubjects)fromsearchbar-child.tsxsearchbar-child.tsxandpinned-searchbar.tsx➕ Additional Notes