Repository navigation
Conversation
components parsed userSubjects from localStorage without a try/catch, so a value that was not a json array crashed the page. read it through readPinnedSubjects, which falls back to an empty list and clears the bad value
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Purpose
12 places parsed
userSubjectsfrom localStorage without a try/catch, so a value that wasnt a JSON array crashed the pageCorresponding issue: closes #559
🖼️ Showcase
After
localStorage.setItem("userSubjects", "oops")and a reload of the home page🔧 Changes
readPinnedSubjects()insrc/lib/utils/pinned-subjects.ts: returns the saved list, or[]and clears the key if its invalid➕ Additional Notes