Repository navigation
Conversation
getPaperById threw a plain error, so a valid id with no paper came back as a 500. throw a CustomError with 404 and use customErrorHandler in the route, and let fetchPaperID pass 400 and 404 through so the paper page redirects home as it intends to
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Purpose
a valid ObjectId with no matching paper returned a 500, bcs
getPaperByIdthrew a plainError, the paper page also never redirected for missing papers it checks for 400/404 axios errors, butfetchPaperIDrethrew everything as a plainError.Corresponding issue: closes #554
🖼️ Showcase
GET /api/paper-by-id/000000000000000000000000: 500 → 404{"message":"paper not found"}GET /paper/000000000000000000000000: error text → 307 redirect to/🔧 Changes
getPaperByIdthrowsCustomError("paper not found", 404)customErrorHandler(from seperate service logic from controller logic for paper-by-id api #436)fetchPaperIDlets 400 and 404 axios errors through so the page's existing redirect works➕ Additional Notes