Skip to content

fix: valgrind on ARM #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
not-matthias wants to merge 10 commits into
base: master
Choose a base branch
from
+2,994 −18
Draft

fix: valgrind on ARM #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8c37d70
feat(callgrind-utils): parse .out into a call graph and emit canonica…
not-matthias Jun 30, 2026
3aef136
test(callgrind-utils): add valgrind-driven fixture snapshot tests
not-matthias Jun 30, 2026
9e775a7
fix(VEX): classify arm64 plain B as Ijk_Boring, not Ijk_Call
not-matthias Jun 30, 2026
11a0bc1
test(callgrind-utils): add --instr-atstart=yes full-trace matrix
not-matthias Jun 30, 2026
83d030a
test(callgrind-utils): add Python fixture with runtime obj-skip
not-matthias Jun 30, 2026
695a1e9
chore: dont ignore libc/ld
not-matthias Jun 30, 2026
facc042
fixup: inst-at-start=yes tests
not-matthias Jun 30, 2026
a85aee4
chore: add aarch snapshots
not-matthias Jun 30, 2026
9bea3b4
test: stabilize callgrind topology snapshots
not-matthias Jun 30, 2026
bdc4911
Fix ARM64 callgrind stack unwinding
not-matthias Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions VEX/priv/guest_arm64_toIR.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7422,7 +7422,7 @@ Bool dis_ARM64_branch_etc(/*MB_OUT*/DisResult* dres, UInt insn,
/* -------------------- B{L} uncond -------------------- */
if (INSN(30,26) == BITS5(0,0,1,0,1)) {
/* 000101 imm26 B (PC + sxTo64(imm26 << 2))
100101 imm26 B (PC + sxTo64(imm26 << 2))
100101 imm26 BL (PC + sxTo64(imm26 << 2))
*/
UInt bLink = INSN(31,31);
ULong uimm64 = INSN(25,0) << 2;
Expand All @@ -7432,7 +7432,11 @@ Bool dis_ARM64_branch_etc(/*MB_OUT*/DisResult* dres, UInt insn,
}
putPC(mkU64(guest_PC_curr_instr + simm64));
dres->whatNext = Dis_StopHere;
dres->jk_StopHere = Ijk_Call;
/* Only BL (which writes the link register) is a call; a plain B is
an ordinary unconditional branch. Mislabelling B as Ijk_Call makes
callgrind treat every branch to a function epilogue / tail target as
a call, corrupting recursive and cyclic call graphs on arm64. */
dres->jk_StopHere = bLink ? Ijk_Call : Ijk_Boring;
DIP("b%s 0x%llx\n", bLink == 1 ? "l" : "",
guest_PC_curr_instr + simm64);
return True;
Expand Down
1 change: 1 addition & 0 deletions callgrind-utils/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
target/
Loading
Loading