Repository navigation
fix: admit messages to exact enrolled offline recipients - #211
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An enrolled recipient becomes unselectable after its Codex client disconnects because message admission first consults only loaded threads. Exact
messages send --to thread:<id>now reads stored identity through the existing read-only runtime client, then uses unchanged mailbox enrollment and cross-root checks. Tab/enrollment discovery and notification process/composer gates retain their existing behavior; no recipient is resumed.Refs #181; Plan0119 offline-admission packet. Owner: ecochran76, primary executor. No overlapping implementation lane; PR210 checkpoint is merged.
Validation: the new CLI regression first failed with the observed
selection_error: session not found, then passed. Four regressions cover offline notify admission, unenrolled denial, cross-root denial, and mismatched returned identity. All 908 source tests, compileall and diff checks passed. Installed offline cancellation/reconnect qualification follows exact merged-main installation; Plan0119 remains open.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.