Skip to content

[jdbc-v2] Treat disable_frameworks_detection as a driver property - #3282

Merged
chernser merged 1 commit into
ClickHouse:mainfrom
piyush15102003:fix/disable-frameworks-detection-driver-prop
Nov 2, 2026
Merged

chernser merged 1 commit into
ClickHouse:mainfrom
piyush15102003:fix/disable-frameworks-detection-driver-prop

Conversation

@piyush15102003

@piyush15102003 piyush15102003 commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary

disable_frameworks_detection is documented as a driver property but had no DriverProperties entry, so buildFinalProperties forwarded it to client-v2. Since #2712 client-v2 rejects unknown keys, so setting the property (any value, URL or Properties form) failed the connection with Unknown and unmapped config properties. The flag was also read from the raw Properties argument before URL parameters were merged, so ?disable_frameworks_detection=true had no effect.

Changes:

  • Add DriverProperties.DISABLE_FRAMEWORKS_DETECTION (default false), so the key stays on the driver side.
  • Read the flag with isSet(...) after buildFinalProperties, so the URL and Properties forms behave the same.
  • Correct the documented default in jdbc.mdx from true to false (detection is on when the key is not set).

Unchanged: other unknown keys are still forwarded to the client and rejected there, and detection stays on when the property is not set.

Closes #3218

Checklist


Note

Low Risk
Scoped JDBC configuration parsing fix with unit tests; behavior change is limited to a previously broken documented driver property.

Overview
Fixes JDBC V2 connections that failed when disable_frameworks_detection was set, because the key was forwarded to client-v2 as an unknown config and rejected.

The PR registers DriverProperties.DISABLE_FRAMEWORKS_DETECTION (default false) so the flag stays on the driver side, resolves it after URL and Properties are merged (URL wins over Properties), and updates jdbc.mdx so the documented default matches behavior. A changelog note and JdbcConfigurationTest cases cover URL vs properties, forwarding of unrelated unknown keys, and that this key is not passed to the client.

Reviewed by Cursor Bugbot for commit 8f5a88a. Bugbot is set up for automated code reviews on this repo. Configure here.

The documented driver property had no DriverProperties entry, so
buildFinalProperties forwarded it to client-v2, which rejects unknown keys
and failed the connection. It was also read from the Properties argument
before URL parameters were merged, so the URL form had no effect.

Add the DriverProperties entry and read the flag from the merged driver
properties. Correct the documented default to false.

Fixes ClickHouse#3218
@chernser
chernser merged commit dd9bec2 into ClickHouse:main Nov 2, 2026
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[jdbc-v2] Documented driver property disable_frameworks_detection makes the connection fail: Unknown and unmapped config properties

2 participants