Repository navigation
Conversation
The documented driver property had no DriverProperties entry, so buildFinalProperties forwarded it to client-v2, which rejects unknown keys and failed the connection. It was also read from the Properties argument before URL parameters were merged, so the URL form had no effect. Add the DriverProperties entry and read the flag from the merged driver properties. Correct the documented default to false. Fixes ClickHouse#3218
chernser
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disable_frameworks_detectionis documented as a driver property but had noDriverPropertiesentry, sobuildFinalPropertiesforwarded it to client-v2. Since #2712 client-v2 rejects unknown keys, so setting the property (any value, URL orPropertiesform) failed the connection withUnknown and unmapped config properties. The flag was also read from the rawPropertiesargument before URL parameters were merged, so?disable_frameworks_detection=truehad no effect.Changes:
DriverProperties.DISABLE_FRAMEWORKS_DETECTION(defaultfalse), so the key stays on the driver side.isSet(...)afterbuildFinalProperties, so the URL andPropertiesforms behave the same.jdbc.mdxfromtruetofalse(detection is on when the key is not set).Unchanged: other unknown keys are still forwarded to the client and rejected there, and detection stays on when the property is not set.
Closes #3218
Checklist
JdbcConfigurationTest: both forms, both values, unset, URL overridingProperties, unknown key still forwarded). The new cases fail onmainand pass with the fix.history/latest/3218.md)Note
Low Risk
Scoped JDBC configuration parsing fix with unit tests; behavior change is limited to a previously broken documented driver property.
Overview
Fixes JDBC V2 connections that failed when
disable_frameworks_detectionwas set, because the key was forwarded to client-v2 as an unknown config and rejected.The PR registers
DriverProperties.DISABLE_FRAMEWORKS_DETECTION(defaultfalse) so the flag stays on the driver side, resolves it after URL andPropertiesare merged (URL wins overProperties), and updatesjdbc.mdxso the documented default matches behavior. A changelog note andJdbcConfigurationTestcases cover URL vs properties, forwarding of unrelated unknown keys, and that this key is not passed to the client.Reviewed by Cursor Bugbot for commit 8f5a88a. Bugbot is set up for automated code reviews on this repo. Configure here.