fix(client-v2,jdbc-v2): handle tagged errors in response streams - #3097
Open
jjj-n wants to merge 2 commits into
Open
fix(client-v2,jdbc-v2): handle tagged errors in response streams#3097jjj-n wants to merge 2 commits into
jjj-n wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 1df2252. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
client-v2.X-ClickHouse-Exception-Tagresponse header and throwServerExceptionwhen it is reached, while preserving ordinary payload bytes and markers with mismatched tags.TIMEOUT_EXCEEDEDerror (code 159) encountered byResultSet.next()toSQLTimeoutExceptionwith SQLStateHYT00, preserving the original cause and vendor code.CHANGELOG.mdanddocs/features.mdfor the user-visible behavior.Compatibility: no existing public method signatures, configuration defaults, or successful result formats are changed. The change intentionally makes tagged server failures visible as exceptions instead of result data.
HEADER_EXCEPTION_TAGis an additive public constant.Closes #2702
Closes #3077
Test
client-v2tests:HttpExceptionInputStreamTest,HttpResponseExceptionTestjdbc-v2test:ResultSetTimeoutTestclient-v2(662 tests) andjdbc-v2(1,500 tests), 2,162 tests total with 0 failures, 0 errors, and 0 skippedpackages/clickhouse-jdbc-alland its required modules packaged successfullyResultSetpaths are covered by focused testsChecklist
CHANGELOG.mddocs/features.md