Skip to content

c++ complain that ciso646 is non standard, and version should be used - #561

Merged
slabko merged 1 commit into
ClickHouse:masterfrom
RoyBellingan:ciso646
Sep 2, 2026
Merged

c++ complain that ciso646 is non standard, and version should be used#561
slabko merged 1 commit into
ClickHouse:masterfrom
RoyBellingan:ciso646

Conversation

@RoyBellingan

Copy link
Copy Markdown
Contributor

Just a small

#if __cplusplus >= 202002L

@slabko

slabko commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Thank you, @RoyBellingan, for taking care of this problem.

Just as a side note, I suggest not using the vendored Abseil and disabling the use of Abseil for Int128 in general with the -DCH_USE_ABSEIL_FOR_BIGNUM=NO build configuration parameter.

Abseil support for Int128 will be removed in the future.

@slabko
slabko merged commit 876cb44 into ClickHouse:master Sep 2, 2026
44 checks passed
@RoyBellingan

Copy link
Copy Markdown
Contributor Author

Thank you for the kind message @slabko !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants