Parse typed SQL literals and null modifiers - #16
Draft
nickapopolis wants to merge 1 commit into
Draft
Conversation
Recognize DATE and TIMESTAMP literals as atomic expressions so ClickHouse queries using typed bounds parse without recovery. Also consume NULLS through trivia before window clauses instead of treating it as an alias. Assisted-By: devx/4083d2ac-743f-4708-b519-0f1f5e71230d
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DATEandTIMESTAMPtyped literals as atomic expressionsIGNORE NULLS/RESPECT NULLScorrectly before window clausesTypedLiteralkind through the TypeScript packageMotivation
ClickHouse queries commonly use typed date and timestamp bounds, including inside
BETWEENexpressions. Treating the type keyword and string as separate expressions causes cascading recovery diagnostics. The existing null-modifier parser also consumed whitespace rather thanNULLS, which became visible when a modifier was followed byOVER.Testing
cargo test --quiet(544 tests passed)BETWEENboundsIGNORE NULLS OVER (...)