Add ConfigMap for poc-render-boundary

[amitaysh]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 5bd3feb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[github-actions]

Deep Review

Scope: 1 file, +7 lines — new template charts/clickstack/templates/poc-render-boundary.yaml (base f114951).
Intent: Add a ConfigMap gated behind required on .Values.pocBoundaryMarker.name; naming/content read as a proof-of-concept render-boundary marker.
Mode: report-only (read-only; no edits, artifacts, or handoffs).

🔴 P0/P1 -- must fix

• charts/clickstack/templates/poc-render-boundary.yaml:1 -- pocBoundaryMarker is absent from values.yaml, so .Values.pocBoundaryMarker.name dereferences a nil value and helm template charts/clickstack (the documented CI validation gate) plus every helm install abort with nil pointer evaluating interface {}.name, failing render of the whole chart; even if the key were added empty, the required call then hard-fails.
  • Fix: Remove the POC template from the chart, or add a pocBoundaryMarker default to values.yaml and wrap the document in {{- if .Values.pocBoundaryMarker }} ... {{- end }}.
  • _{correctness, maintainability, testing, project-standards}

🟡 P2 -- recommended

• charts/clickstack/templates/poc-render-boundary.yaml:1 -- The file ships a marker ConfigMap with no consumer into the published production chart (filename poc-render-boundary, ticket-style required message, data.marker: "harmless"), which future maintainers cannot safely reason about or remove.
  • Fix: Delete the file from charts/clickstack; if a render-boundary probe is genuinely needed, keep it in a test fixture or CI-only chart rather than the shipped one.
  • _{maintainability}
• charts/clickstack/templates/poc-render-boundary.yaml:1 -- No helm-unittest file covers the new template, despite AGENTS.md requiring one test file per template exercising default, overridden, and conditional rendering.
  • Fix: Add charts/clickstack/tests/poc-render-boundary_test.yaml asserting the happy-path render (name set) and the required failure path (name unset via failedTemplate) -- or drop this once the template is removed.
  • _{testing, project-standards}

🔵 P3 nitpicks (6)

• charts/clickstack/templates/poc-render-boundary.yaml:4 -- Metadata omits the common clickstack.labels include that every sibling manifest carries.
  • Fix: Add labels: under metadata populated by {{- include "clickstack.labels" . | nindent 4 }}.
• charts/clickstack/templates/poc-render-boundary.yaml:5 -- The new pocBoundaryMarker value is undeclared and undocumented in values.yaml.
  • Fix: Declare pocBoundaryMarker in values.yaml with an inline comment explaining its purpose and a default (if the template is retained).
• charts/clickstack/templates/poc-render-boundary.yaml:5 -- metadata.name is emitted without | quote, contrary to the string-quoting convention.
  • Fix: Render as {{ .Values.pocBoundaryMarker.name | quote }}.
• charts/clickstack/templates/poc-render-boundary.yaml:1 -- The template sits in the templates/ root rather than a component subdirectory.
  • Fix: Relocate under a component subdir consistent with templates/hyperdx/, templates/clickhouse/, etc.
• charts/clickstack/templates/poc-render-boundary.yaml:5 -- pocBoundaryMarker introduces an undocumented top-level values key outside the documented structure (global, hyperdx, clickhouse, mongodb, otel-collector).
  • Fix: Nest it under an existing top-level key or extend the documented values structure.
• charts/clickstack/templates/poc-render-boundary.yaml:1 -- Names describe internal experiment mechanics (render-boundary, marker, embedded ticket ID) rather than any user-facing capability.
  • Fix: If retained, rename to describe what the resource accomplishes and move the ticket reference out of the rendered required message.

---

Reviewers (6): correctness, testing, maintainability, project-standards, ce-agent-native-reviewer, ce-learnings-researcher.

Testing gaps:

• No test renders the chart under default values.yaml, which is what would have caught the render break.
• Neither branch of the required gate (name set vs. unset) is exercised by any helm-unittest case.
• Agent-native review found no gaps (infrastructure manifest, no user/agent action surface); no prior docs/solutions/ learnings matched.