chore(deps): bump clickhouse-operator-helm version to v0.0.6

[GrigoryPervakov]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: 849789b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Deep Review

Scope: chore(deps) bump of the clickhouse-operator-helm subchart 0.0.2 → 0.0.6, a values-key rename enable → enabled under clickhouse-operator.{webhook,certManager,crd}, and an integration-test kubectl wait tweak. Base f114951.

The central risk — that renaming enable → enabled silently no-ops the toggles because Helm ignores unknown subchart keys — was verified and cleared: the upstream ClickHouse/clickhouse-operator chart gates on .Values.*.enable at v0.0.2 and on .Values.*.enabled at v0.0.6, so the rename correctly tracks the subchart's own schema change (CRD stays installed, webhook/certManager stay disabled). The assert.sh field-selector change is also correct: Succeeded (completed Job) pods never satisfy --for=condition=Ready, so excluding them prevents a spurious kubectl wait timeout while still gating on Failed/Pending/Running pods.

🔴 P0/P1 -- must fix

• charts/clickstack-operators/Chart.yaml:8 -- The chart's own version stays at 1.0.0 while its packaged content changes, but tag clickstack-operators-1.0.0 already exists and release.yml runs chart-releaser-action with skip_existing: true, so the updated operators chart is never republished; scripts/update-chart-versions.js only rewrites charts/clickstack, so the changeset flow does not bump this chart either.
  • Fix: Bump version in charts/clickstack-operators/Chart.yaml (e.g. to 1.0.1) so chart-releaser publishes the new package, and add the operators chart to scripts/update-chart-versions.js if changeset-driven bumps should cover it.
  • _{project-standards}

🟡 P2 -- recommended

• charts/clickstack-operators/values.yaml:11 -- The enable → enabled rename changes CRD/webhook/certManager rendering, but charts/clickstack-operators has no helm-unittest suite and CI runs helm unittest/helm template only against charts/clickstack, so a mismatched subchart key name would fail silently with no test signal.
  • Fix: Add a helm-unittest suite under charts/clickstack-operators/tests/ asserting the subchart receives crd.enabled=true and webhook.enabled/certManager.enabled=false, and wire helm unittest charts/clickstack-operators into helm-test.yaml.
  • _{testing, project-standards, correctness, reliability, maintainability}

🔵 P3 nitpicks (2)

• .changeset/bump-clickhouse-operator-v0.0.6.md:5 -- The changeset summary only states the version bump and omits the enable → enabled key rename, which is the load-bearing content for the release note since consumers overriding the old keys must update them.

  • Fix: Note the clickhouse-operator.{webhook,certManager,crd}.enable → .enabled rename in the changeset body.

• charts/clickstack-operators/values.yaml:9 -- The comment links to the prose operator overview page rather than the chart's values/schema, so a maintainer cannot verify the enabled key spelling from the cited reference.

  • Fix: Point the comment at the clickhouse-operator-helm chart's values.yaml/schema reference.

---

Reviewers (5): correctness, testing, maintainability, project-standards, reliability.

Testing gaps:

• No assertion confirms CRDs install and webhook/certManager stay disabled under the v0.0.6 enabled keys — the only coverage is the full-stack integration suite, which asserts general readiness, not these specific toggles.
• No coverage for the operator upgrade path (existing 0.0.2 CRDs → 0.0.6); validate the CRD changelog for 0.0.3–0.0.6 before rolling to already-deployed ClickHouseCluster resources.