Skip to content

Match '.google.' literally in Q23 of the DataFrame entries - #2426

Merged
alexey-milovidov merged 8 commits into
ClickHouse:mainfrom
jan-krueger:q23-literal-google
Oct 12, 2026
Merged

alexey-milovidov merged 8 commits into
ClickHouse:mainfrom
jan-krueger:q23-literal-google

Conversation

@jan-krueger

Copy link
Copy Markdown
Contributor

Q23 is URL NOT LIKE '%.google.%', but the Polars, pandas and Dask versions pass '.google.' to str.contains, which treats it as a regex by default (Polars, pandas, Dask). So the dots match any character, and it also matches things like xgooglex. This PR makes the matches literal.

@CLAassistant

CLAassistant commented Oct 6, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@alexey-milovidov alexey-milovidov added the machine:all PR benchmark on every machine type label Oct 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Results for polars are ready for: c6a.2xlarge, c6a.4xlarge, c6a.metal, c7a.metal-48xl, c8g.4xlarge.
The result files are committed as 33b5225.
Preview of the benchmark page with these results
The run of dask on c6a.4xlarge did not produce results.
The run of pandas on c6a.2xlarge did not produce results.
The run of pandas on c6a.4xlarge did not produce results.
The run of pandas on c6a.large did not produce results.
The run of pandas on c6a.xlarge did not produce results.
The run of pandas on c8g.4xlarge did not produce results.
The run of pandas on t3a.small did not produce results.
The run of polars-dataframe on c6a.2xlarge did not produce results.
The run of polars-dataframe on c6a.4xlarge did not produce results.
The run of polars-dataframe on c6a.large did not produce results.
The run of polars-dataframe on c6a.xlarge did not produce results.
The run of polars-dataframe on c8g.4xlarge did not produce results.
The run of polars-dataframe on t3a.small did not produce results.

Logs:

@github-actions

Copy link
Copy Markdown
Contributor

Results for polars are ready for: c8g.metal-48xl.
Results for polars-dataframe are ready for: c6a.metal, c7a.metal-48xl.
The result files are committed as a562b4e.
Preview of the benchmark page with these results

Logs:

@github-actions

Copy link
Copy Markdown
Contributor

Results for dask are ready for: c6a.metal, c7a.metal-48xl, c8g.metal-48xl.
Results for polars are ready for: c6a.xlarge.
The result files are committed as 79c2836.
Preview of the benchmark page with these results

Logs:

@github-actions

Copy link
Copy Markdown
Contributor

Results for pandas are ready for: c6a.metal, c7a.metal-48xl.
The result files are committed as 32f5652.
Preview of the benchmark page with these results

Logs:

@github-actions

Copy link
Copy Markdown
Contributor

Results for pandas are ready for: c8g.metal-48xl.
The result files are committed as 94da697.
Preview of the benchmark page with these results

Logs:

@github-actions

Copy link
Copy Markdown
Contributor

Results for polars are ready for: c6a.large.
The result files are committed as 6ad9610.
Preview of the benchmark page with these results

Logs:

@github-actions

Copy link
Copy Markdown
Contributor

Results for polars are ready for: t3a.small.
The result files are committed as 83d5714.
Preview of the benchmark page with these results

Logs:

@github-actions

Copy link
Copy Markdown
Contributor

The run of dask on c6a.2xlarge did not produce results.
The run of dask on c6a.large did not produce results.
The run of dask on c6a.xlarge did not produce results.
The run of dask on c8g.4xlarge did not produce results.
The run of dask on t3a.small did not produce results.

Logs:

@alexey-milovidov
alexey-milovidov merged commit b7b4a4c into ClickHouse:main Oct 12, 2026
2 of 3 checks passed

This branch is waiting to be deployed

1 waiting deployment
benchmark-approval — 83d57143 Waiting Oct 12, 2026 by robot-clickhouse via launch #782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

machine:all PR benchmark on every machine type

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants