Skip to content

test: pin persisted-nonce reuse, foreign-owned token refusal, weight-body caps - #10

Open
SaulBuilds wants to merge 2 commits into
mainfrom
dgx/qg-pins-1022
Open

SaulBuilds wants to merge 2 commits into
mainfrom
dgx/qg-pins-1022

Conversation

@SaulBuilds

@SaulBuilds SaulBuilds commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Tests only.

What

  • execution: executor_reuses_the_persisted_nonce_after_a_restart. After a restart before the commitment lands, the executor must commit to the nonce already persisted for the job.
  • supervision/auth: read_existing_token_refuses_a_file_owned_by_another_uid. It uses a root-owned system file and only stats and reads it, never writes. It's skipped when the test runs as that file's owner.
  • executor: tests/weight_body_cap.rs, using loopback servers:
    • a declared Content-Length over the cap is refused before the body is read;
    • a chunked body with no length is refused once it passes the cap;
    • a body within the cap is returned.

Standard: met

  • Revert check: each of these was green under the existing suite and now turns its named test red: ignoring the persisted nonce, dropping the uid comparison, removing either weight-body cap.
  • Other guards: I revert-checked 17 more (outbound timeouts and no-redirect, job input cap and its FIFO/symlink/regular-file gates, seal replica binding, model-hash binding, token symlink refusal, bid supersede and queue cap, minted-nonce use, the committed-without-nonce abort, the bearer gate, /health redaction). Each is already red under an existing test.
  • Checks: cargo test -p node-agent -p supervision -p executor green.
  • Pre-existing on main, not touched here: cargo fmt --check reports diffs across most files with rustc 1.93, and clippy -D warnings fails in the config crate.

🤖 Generated with Claude Code

https://claude.ai/code/session_01KGMeatV8UjtCB4CTbWuAv4

SaulBuilds and others added 2 commits October 22, 2026 17:45
…efusal

- execution: after a restart before the commitment lands, the executor must
  commit to the nonce already persisted for the job, not the static fallback.
  Revert check: ignoring the persisted nonce turns it red (the existing suite
  stayed green).
- supervision/auth: read_existing_token refuses an inode owned by another
  uid (stat + read of a root-owned system file only; skipped when running as
  its owner). Revert check: dropping the uid comparison turns it red.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KGMeatV8UjtCB4CTbWuAv4
Loopback servers: a declared Content-Length over the cap is refused before
the body is read; a chunked body with no length is refused once it streams
past the cap; a body within the cap is returned.

Revert check: each cap removed on its own went undetected by the existing
suite; each now turns its named test red.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KGMeatV8UjtCB4CTbWuAv4
@SaulBuilds
SaulBuilds requested a review from a team as a code owner October 23, 2026 00:52

@BerryManifold BerryManifold left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated Codex static review of b94fdc2c211535ecec98508d2bb5631f10799211 is complete. Result: incomplete; details retained privately. Details and coverage limits are recorded in the project's private review log. No tests were executed by this reviewer. Both account submissions represent the same Codex review, not independent reviews.

@Matr0xshka Matr0xshka left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated Codex static review of b94fdc2c211535ecec98508d2bb5631f10799211 is complete. Result: incomplete; details retained privately. Details and coverage limits are recorded in the project's private review log. No tests were executed by this reviewer. Both account submissions represent the same Codex review, not independent reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants