LibRed: metadata surface, stored queries, complex columns, and byte-parity writes

.gitattributes

@@ -3,6 +3,20 @@
 ###############################################################################
 * text=auto
 
+###############################################################################
+# C# sources check out CRLF on every platform.
+#
+# .editorconfig pins end_of_line = crlf for [*.cs] and [*.{cs,vb}], and
+# EnforceCodeStyleInBuild makes IDE0055 a build error in src. Under `text=auto`
+# alone the working tree takes the platform's ending, so a Linux or macOS
+# checkout gets LF and every line then violates that rule while Windows builds
+# clean. Pinning the checkout here keeps the one setting that decides this in
+# agreement with the one that enforces it. The index is unaffected — it stores
+# LF either way.
+###############################################################################
+*.cs text eol=crlf
+*.vb text eol=crlf
+
 ###############################################################################
 # Set default behavior for command prompt diff.
 #

.github/workflows/pull_request.yml

@@ -103,6 +103,7 @@ jobs:
               - 'src/LibRed/**'
               - 'test/LibRed.Ado.Tests/**'
               - 'test/LibRed.Core.Tests/**'
+              - 'test/LibRed.Core.AccessTests/**'
               - 'test/LibRed.EFCore.Tests/**'
               - 'test/LibRed.Engine.Tests/**'
               - 'test/LibRed.Engine.AccessTests/**'
@@ -676,6 +677,13 @@ jobs:
       - name: 'Run Tests: LibRed.Engine.Tests'
         if: env.skipTests != 'true'
         run: dotnet test ./test/LibRed.Engine.Tests --configuration ${{ env.buildConfiguration }} -p:FixedTestOrder=${{ env.deterministicTests }} --blame-hang-timeout 3m
+      # The file-format half of LibRed.Core.Tests. It reads and writes .accdb files with LibRed alone — the
+      # cross-checks against the real Access engine live in LibRed.Core.AccessTests — so it belongs on this
+      # matrix rather than the Windows one, and reading the on-disk format on Linux/macOS/ARM64 is the part
+      # of the cross-platform claim that was previously only asserted for the engine.
+      - name: 'Run Tests: LibRed.Core.Tests'
+        if: always() && env.skipTests != 'true'
+        run: dotnet test ./test/LibRed.Core.Tests --configuration ${{ env.buildConfiguration }} -p:FixedTestOrder=${{ env.deterministicTests }} --blame-hang-timeout 3m
 
   # The rest of the LibRed suites cross-check LibRed's output against the real engine over OLE DB,
   # so unlike the job above they do need Windows with ACE installed.
@@ -718,10 +726,12 @@ jobs:
               }
               $v
           }
-      - name: 'Run Tests: LibRed.Core.Tests'
+      # The file-format tests that cross-check against ACE. Their ACE-free half runs on the five-platform
+      # LibRed job above.
+      - name: 'Run Tests: LibRed.Core.AccessTests'
         if: env.skipTests != 'true'
         shell: pwsh
-        run: dotnet test .\test\LibRed.Core.Tests --configuration '${{ env.buildConfiguration }}' -p:FixedTestOrder=${{ env.deterministicTests }} --blame-hang-timeout 5m
+        run: dotnet test .\test\LibRed.Core.AccessTests --configuration '${{ env.buildConfiguration }}' -p:FixedTestOrder=${{ env.deterministicTests }} --blame-hang-timeout 5m
       # The engine tests that cross-check against ACE. They belong here rather than in the cross-platform
       # LibRed job above, which runs on five platforms precisely to prove LibRed needs no ACE at all.
       - name: 'Run Tests: LibRed.Engine.AccessTests'

AGENTS.md

@@ -32,6 +32,14 @@ dotnet build EFCore.Jet.sln
 
 Assemblies are **strong-name signed** using `Key.snk`. `TreatWarningsAsErrors=True` is set globally — fix all warnings.
 
+`src/Directory.Build.props` also turns on `AnalysisMode=Recommended` and `EnforceCodeStyleInBuild`, so **in `src`
+every CA/IDE diagnostic is a build error** (the test projects import the repo-root props and stay on the SDK
+default). Fix them rather than suppress them; where a rule's own fix would change behaviour, a `#pragma` carries a
+written reason. Two traps: `dotnet format whitespace` handles IDE0055 and `dotnet format style` the other IDE rules,
+but **never run either against a single project when the change can touch `src/Shared`** — IDE0005 is evaluated per
+project, and formatting one will delete a using the other four consumers still need. The implicit usings those
+shared files rely on are declared once in `src/Shared/SharedSource.props`.
+
 ### Local EFCore Repository (optional)
 
 To develop against a local EF Core build instead of NuGet packages, copy `Development.props.sample` to `Development.props` and set `LocalEFCoreRepository` to your EF Core checkout. That local build must be compiled with `AssemblyVersion=11.0.0.0` to avoid binding conflicts.
@@ -267,9 +275,11 @@ The Jet provider (`src/EFCore.Jet*`) has **no** equivalent — it does no ACE ve
 `JetTypeMappingSource` keeps `{"bigint", …}` commented out, so `long` maps to `decimal(20,0)` regardless of the
 installed engine. That asymmetry is deliberate for now; don't "fix" one side by assuming the other behaves the same.
 
-**Build configuration:** `src/LibRed/Directory.Build.props` bypasses `src/Directory.Build.props` (it imports the
-repo-root props directly) to set its own build options — not packable, no documentation file, its own `NoWarn`,
-`ImplicitUsings`/`Nullable` on. The Windows stamp is no longer a reason: each driver-bound project applies
+**Build configuration:** `src/LibRed/Directory.Build.props` **imports** `src/Directory.Build.props` and adds to it:
+`ImplicitUsings`/`Nullable` on, `GenerateDocumentationFile` on (IDE0005 cannot run without it), its own `NoWarn`,
+and a LibRed-specific package readme in place of the Jet one the repo root packs. Because it imports rather than
+bypasses, the LibRed projects inherit the same `AnalysisMode`/`EnforceCodeStyleInBuild` as the rest of `src`. The
+Windows stamp is no longer a reason for any of it: each driver-bound project applies
 `[SupportedOSPlatform("windows")]` itself. Strong-naming is preserved.
 
 **SQL pipeline** (always run end-to-end, even for trivial queries, so new features add

CLAUDE.md

@@ -31,6 +31,14 @@ dotnet build EFCore.Jet.sln
 
 Assemblies are **strong-name signed** using `Key.snk`. `TreatWarningsAsErrors=True` is set globally — fix all warnings.
 
+`src/Directory.Build.props` also turns on `AnalysisMode=Recommended` and `EnforceCodeStyleInBuild`, so **in `src`
+every CA/IDE diagnostic is a build error** (the test projects import the repo-root props and stay on the SDK
+default). Fix them rather than suppress them; where a rule's own fix would change behaviour, a `#pragma` carries a
+written reason. Two traps: `dotnet format whitespace` handles IDE0055 and `dotnet format style` the other IDE rules,
+but **never run either against a single project when the change can touch `src/Shared`** — IDE0005 is evaluated per
+project, and formatting one will delete a using the other four consumers still need. The implicit usings those
+shared files rely on are declared once in `src/Shared/SharedSource.props`.
+
 ### Local EFCore Repository (optional)
 
 To develop against a local EF Core build instead of NuGet packages, copy `Development.props.sample` to `Development.props` and set `LocalEFCoreRepository` to your EF Core checkout. That local build must be compiled with `AssemblyVersion=11.0.0.0` to avoid binding conflicts.
@@ -282,9 +290,11 @@ The Jet provider (`src/EFCore.Jet*`) has **no** equivalent — it does no ACE ve
 `JetTypeMappingSource` keeps `{"bigint", …}` commented out, so `long` maps to `decimal(20,0)` regardless of the
 installed engine. That asymmetry is deliberate for now; don't "fix" one side by assuming the other behaves the same.
 
-**Build configuration:** `src/LibRed/Directory.Build.props` bypasses `src/Directory.Build.props` (it imports the
-repo-root props directly) to set its own build options — not packable, no documentation file, its own `NoWarn`,
-`ImplicitUsings`/`Nullable` on. The Windows stamp is no longer a reason: each driver-bound project applies
+**Build configuration:** `src/LibRed/Directory.Build.props` **imports** `src/Directory.Build.props` and adds to it:
+`ImplicitUsings`/`Nullable` on, `GenerateDocumentationFile` on (IDE0005 cannot run without it), its own `NoWarn`,
+and a LibRed-specific package readme in place of the Jet one the repo root packs. Because it imports rather than
+bypasses, the LibRed projects inherit the same `AnalysisMode`/`EnforceCodeStyleInBuild` as the rest of `src`. The
+Windows stamp is no longer a reason for any of it: each driver-bound project applies
 `[SupportedOSPlatform("windows")]` itself. Strong-naming is preserved.
 
 **SQL pipeline** (always run end-to-end, even for trivial queries, so new features add

src/Directory.Build.props

@@ -8,6 +8,10 @@
     <NoWarn>$(NoWarn);CS1574;CS1587;CS1591;EF1001;NU1903</NoWarn>
     <!--<CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)..\rulesets\EFCore.ruleset</CodeAnalysisRuleSet>-->
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
+    <!-- Code analysis and code-style analysis, for the shipping code only. The test projects import the
+         repo-root props instead, so they stay on the SDK's default rule set. -->
+    <AnalysisMode>Recommended</AnalysisMode>
+    <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
   </PropertyGroup>
 
   <PropertyGroup>

src/EFCore.Jet.Common/Design/Internal/JetAnnotationCodeGenerator.cs

@@ -35,7 +35,7 @@ protected override bool IsHandledByConvention(IModel model, IAnnotation annotati
             // CHECK: Jet default schema handling.
             if (annotation.Name == RelationalAnnotationNames.DefaultSchema)
             {
-                return string.Equals(null, (string?)annotation.Value);
+                return string.Equals(null, (string?)annotation.Value, StringComparison.Ordinal);
             }
 
             return annotation.Name == JetAnnotationNames.ValueGenerationStrategy

src/EFCore.Jet.Common/Design/Internal/JetCSharpRuntimeAnnotationCodeGenerator.cs

@@ -152,4 +152,4 @@ public override void Generate(IRelationalPropertyOverrides overrides, CSharpRunt
 
         base.Generate(overrides, parameters);
     }
-}
+}

src/EFCore.Jet.Common/Diagnostics/ConflictingValueGenerationStrategiesEventData.cs

@@ -38,6 +38,10 @@ public class ConflictingValueGenerationStrategiesEventData(
         /// <summary>
         ///     The property.
         /// </summary>
+        // CA1716 objects to "Property" as a VB keyword; it is the name EF Core's own PropertyEventData uses,
+        // and this type is consumed through that same diagnostics surface.
+#pragma warning disable CA1716
         public virtual IProperty Property { get; } = property;
+#pragma warning restore CA1716
     }
-}
+}

src/EFCore.Jet.Common/Diagnostics/Internal/JetLoggingDefinitions.cs

@@ -8,6 +8,9 @@ namespace EntityFrameworkCore.Jet.Diagnostics.Internal
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
+    // CA1051 wants properties, but a LoggingDefinitions class is a cache of lazily-built event definitions that
+    // the logger extensions assign into by field; EF Core's own SqlServerLoggingDefinitions is written the same way.
+#pragma warning disable CA1051
     public class JetLoggingDefinitions : RelationalLoggingDefinitions
     {
         /// <summary>
@@ -162,4 +165,5 @@ public class JetLoggingDefinitions : RelationalLoggingDefinitions
         /// </summary>
         public EventDefinitionBase? LogConflictingValueGenerationStrategies;
     }
+#pragma warning restore CA1051
 }

src/EFCore.Jet.Common/EFCore.Jet.Common.csproj

@@ -16,9 +16,7 @@
 	  <PackageReference Include="Microsoft.EntityFrameworkCore.Relational" />
 	</ItemGroup>
 
-	<ItemGroup>
-		<Compile Include="..\Shared\*.cs" />
-	</ItemGroup>
+	<Import Project="..\Shared\SharedSource.props" />
 
 	<ItemGroup>
 		<None Update="Properties\JetStrings.Designer.tt">
@@ -37,9 +35,6 @@
 
 	<ItemGroup>
 		<Using Include="System.Data.Common" />
-		<Using Include="System.Diagnostics" />
-		<Using Include="System.Linq.Expressions" />
-		<Using Include="System.Reflection" />
 		<Using Include="Microsoft.EntityFrameworkCore" />
 		<Using Include="Microsoft.EntityFrameworkCore.ChangeTracking" />
 		<Using Include="Microsoft.EntityFrameworkCore.Diagnostics" />

src/EFCore.Jet.Common/Extensions/JetDbFunctionsExtensions.cs

@@ -778,4 +778,4 @@ public static int ByteArrayLength(
 
         #endregion Population variance
     }
-}
+}

src/EFCore.Jet.Common/Extensions/JetModelExtensions.cs

@@ -74,7 +74,7 @@ public static void SetJetIdentityIncrement(this IMutableModel model, int? increm
         /// <param name="fromDataAnnotation"> Indicates whether the configuration was specified using a data annotation. </param>
         public static int? SetJetIdentityIncrement(
             this IConventionModel model, int? increment, bool fromDataAnnotation = false)
-            => (int?) model.SetOrRemoveAnnotation(
+            => (int?)model.SetOrRemoveAnnotation(
                 JetAnnotationNames.IdentityIncrement,
                 increment,
                 fromDataAnnotation)?.Value;

src/EFCore.Jet.Common/Infrastructure/JetDualTable.cs

@@ -32,13 +32,16 @@ public static class JetDualTable
         /// <summary>
         /// The DUAL table or query
         /// </summary>
-        public static string CustomName = "";
+        public static string CustomName { get; set; } = "";
         //MSysRelationships
         //MSysAccessStorage
         //#Dual
         //(SELECT COUNT(*) FROM MSysAccessStorage)
 
-        public static string DetectedName = "#Dual";
+        /// <summary>
+        /// The DUAL table or query the scaffolding factory last detected in the database.
+        /// </summary>
+        public static string DetectedName { get; set; } = "#Dual";
 
         /// <summary>
         /// The name to generate into SQL: the user's <see cref="CustomName"/> when one has been set,
@@ -49,4 +52,4 @@ public static string Name
                 ? DetectedName
                 : CustomName;
     }
-}
+}

src/EFCore.Jet.Common/Internal/JetLoggerExtensions.cs

@@ -1,5 +1,11 @@
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
+// Every method here follows EF Core's own logger-extension shape: the message template comes from an
+// EventDefinition rather than being a literal, and the call is already guarded by ShouldLog. That is what
+// CA2254 (varying template), CA1848 (LoggerMessage delegates) and CA1873 (params array) each object to, and
+// EF Core's own generated extensions are written the same way.
+#pragma warning disable CA1848, CA1873, CA2254
+
 namespace EntityFrameworkCore.Jet.Internal
 {
     /// <summary>
@@ -486,4 +492,4 @@ public static void ReflexiveConstraintIgnored(
             // No DiagnosticsSource events because these are purely design-time messages
         }
     }
-}
+}

src/EFCore.Jet.Common/Internal/JetModelValidator.cs

@@ -1,8 +1,8 @@
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-using System.Text;
 using EntityFrameworkCore.Jet.Metadata;
 using EntityFrameworkCore.Jet.Metadata.Internal;
+using System.Text;
 
 namespace EntityFrameworkCore.Jet.Internal
 {

src/EFCore.Jet.Common/Metadata/Conventions/JetIndexConvention.cs

@@ -33,7 +33,11 @@ public class JetIndexConvention(
     IPropertyNullabilityChangedConvention,
     IPropertyAnnotationChangedConvention
 {
+    // Unread: Jet's index filter is the fixed "IGNORE NULL", so nothing here quotes an identifier. The
+    // constructor parameter stays because it is the signature EF Core's convention-set builder constructs.
+#pragma warning disable IDE0052
     private readonly ISqlGenerationHelper _sqlGenerationHelper = sqlGenerationHelper;
+#pragma warning restore IDE0052
 
     /// <summary>
     ///     Dependencies for this service.
@@ -144,7 +148,7 @@ public virtual void ProcessPropertyAnnotationChanged(
         }
     }
 
-    private void SetIndexFilter(IConventionIndexBuilder indexBuilder, bool columnNameChanged = false)
+    private static void SetIndexFilter(IConventionIndexBuilder indexBuilder, bool columnNameChanged = false)
     {
         var index = indexBuilder.Metadata;
         if (index.IsUnique
@@ -166,11 +170,11 @@ private void SetIndexFilter(IConventionIndexBuilder indexBuilder, bool columnNam
         }
     }
 
-    private string CreateIndexFilter(List<string> nullableColumns)
+    private static string CreateIndexFilter(List<string> nullableColumns)
     {
         var builder = new StringBuilder();
 
-        if (nullableColumns.Any())
+        if (nullableColumns.Count > 0)
         {
             builder.Append("IGNORE NULL");
         }
@@ -214,4 +218,4 @@ private string CreateIndexFilter(List<string> nullableColumns)
 
         return nullableColumns;
     }
-}
+}

src/EFCore.Jet.Common/Metadata/Conventions/JetOnDeleteConvention.cs

@@ -43,7 +43,7 @@ protected override DeleteBehavior GetTargetDeleteBehavior(IConventionForeignKey
         return ProcessSkipNavigations(foreignKey.GetReferencingSkipNavigations()) ?? deleteBehavior;
     }
 
-    private DeleteBehavior? ProcessSkipNavigations(IEnumerable<IConventionSkipNavigation> skipNavigations)
+    private static DeleteBehavior? ProcessSkipNavigations(IEnumerable<IConventionSkipNavigation> skipNavigations)
     {
         var skipNavigation = skipNavigations
             .FirstOrDefault(
@@ -121,4 +121,4 @@ public virtual void ProcessEntityTypeAnnotationChanged(
             }
         }
     }
-}
+}

src/EFCore.Jet.Common/Metadata/Conventions/JetSharedTableConvention.cs

@@ -22,4 +22,4 @@ public class JetSharedTableConvention(
     /// <inheritdoc />
     protected override bool IndexesUniqueAcrossTables
         => false;
-}
+}

src/EFCore.Jet.Common/Metadata/Conventions/JetValueGenerationStrategyConvention.cs

@@ -85,7 +85,7 @@ public virtual void ProcessModelFinalizing(
             static bool IsStrategyNoneNeeded(IReadOnlyProperty property, StoreObjectIdentifier storeObject)
             {
                 if (property.ValueGenerated == ValueGenerated.OnAdd
-                    && property.TryGetDefaultValue(storeObject, out _) == false
+                    && !property.TryGetDefaultValue(storeObject, out _)
                     && property.GetDefaultValueSql(storeObject) == null
                     && property.GetComputedColumnSql(storeObject) == null
                     && property.DeclaringType.Model.GetValueGenerationStrategy() == JetValueGenerationStrategy.IdentityColumn)

src/EFCore.Jet.Common/Metadata/Conventions/JetValueGeneratorConvention.cs

@@ -84,7 +84,7 @@ public override void ProcessPropertyAnnotationChanged(
         /// <param name="property">The property.</param>
         /// <param name="storeObject">The identifier of the store object.</param>
         /// <returns>The store value generation strategy to set for the given property.</returns>
-        public new static ValueGenerated? GetValueGenerated(IReadOnlyProperty property, in StoreObjectIdentifier storeObject)
+        public static new ValueGenerated? GetValueGenerated(IReadOnlyProperty property, in StoreObjectIdentifier storeObject)
             => RelationalValueGenerationConvention.GetValueGenerated(property, storeObject)
                       ?? (property.GetValueGenerationStrategy(storeObject) != JetValueGenerationStrategy.None
                           ? ValueGenerated.OnAdd

src/EFCore.Jet.Common/Metadata/Internal/JetAnnotationProvider.cs

@@ -1,5 +1,5 @@
-using System.Globalization;
 using Microsoft.EntityFrameworkCore.Metadata.Internal;
+using System.Globalization;
 
 namespace EntityFrameworkCore.Jet.Metadata.Internal
 {
@@ -96,7 +96,7 @@ public override IEnumerable<IAnnotation> For(IColumn column, bool designTime)
             else
             {
                 if (column is JsonColumn) yield break;
-                property = column.PropertyMappings.First().Property;
+                property = column.PropertyMappings[0].Property;
                 if (property.DeclaringType is IEntityType entityType)
                 {
                     // Only return auto increment for integer single column primary key

src/EFCore.Jet.Common/Metadata/JetValueGenerationStrategy.cs

@@ -8,4 +8,4 @@ public enum JetValueGenerationStrategy
         IdentityColumn,
         Sequence
     }
-}
+}

src/EFCore.Jet.Common/Migrations/Internal/JetMigrationDatabaseLock.cs

@@ -40,6 +40,8 @@ public void Dispose()
         {
             if (!e.Message.Contains("cannot find the input table")) throw;
         }
+
+        GC.SuppressFinalize(this);
     }
 
     /// <summary>
@@ -58,5 +60,7 @@ public async ValueTask DisposeAsync()
         {
             if (!e.Message.Contains("cannot find the input table")) throw;
         }
+
+        GC.SuppressFinalize(this);
     }
-}
+}