Skip to content

Update dependencies and GitHub Actions to latest majors - #21

Merged
ChumpChief merged 48 commits into
ChumpChief:mainfrom
ChumpChief-bot:deps/update-to-latest
Nov 8, 2026
Merged

ChumpChief merged 48 commits into
ChumpChief:mainfrom
ChumpChief-bot:deps/update-to-latest

Conversation

@ChumpChief-bot

Copy link
Copy Markdown
Contributor

Summary

Updates the project's dependencies and GitHub Actions to their latest majors. 20 files changed; no source files under any src/ touched.

Dependency changes

Area From To
pnpm 10.34.9 12.18.0 (packageManager, single source of truth)
nx 21.3.0 24.0.5
Node (runtime) 22 (implied) 26.13.0 (exact pin, see below)
eslint + typescript-eslint 9 / 8.x 10.14.0 / 8.72.1
webpack / ts-loader 5.x / 9.x 5.112.2 / 9.6.2 (+ webpack-cli 7, dev-server 6)
typescript 5.x 6.0.3
jest, react, react-dom — 30.5.2, 19.3.1

Notable ripple effects:

  • Lockfile v9.0, two-document format — pnpm 12 records its own version/checksum in a leading boot document.
  • pnpm-workspace.yaml: onlyBuiltDependencies → allowBuilds — pnpm 11+ renamed the key family (old key silently ignored). Approvals: nx (postinstall downloads its native binary), @parcel/watcher (via jest-haste-map), and unrs-resolver (via jest-resolve). All three are N-API packages whose prebuilt platform binaries are the primary path.
  • nx.json: added "analytics": false (suppresses nx 24's first-run prompt, which would otherwise rewrite the file).
  • eslint-config-shared: eslint added as devDependency to satisfy the peer chain under pnpm's isolated layout; react.mjs pins version: "19.x" instead of "detect" with an explanatory comment — the detect path calls context.getFilename(), which ESLint 10 removed (upstream: [Bug]: TypeError: Error while loading rule 'react/display-name': sourceCode.getAllComments is not a function jsx-eslint/eslint-plugin-react#3970). The plugin's ^9.7 peer cap produces one unavoidable peer warning until upstream bumps it.
  • Transitive refresh: all locked transitive versions re-resolved to the newest within their declared ranges (no direct ranges touched). pnpm audit: 39 findings (24 high) → 3. The residue is unfixable in-repo: glob@10.5.0 (test-exclude/jest chain allows 10.x only), minimatch@10.2.5 (nx allows 10.x only), deepmerge@4.3.1 (no patched version published).

GitHub Actions changes

Action From To
actions/checkout v4 v7.0.1 (8×)
pnpm/setup — v3.1.2 (4×, new)
actions/setup-node v4 removed
pnpm/action-setup v4 removed
actions/create-github-app-token v1 v3.3.0 (6×)
actions/github-script v7 v9.0.0 (11×)
  • All references pinned to exact version tags (not floating majors, not SHAs).
  • pnpm/setup@v3 replaces both setup actions: it installs pnpm (from packageManager) and Node (from devEngines.runtime), so no node-version inputs exist anywhere in the workflows. install: false keeps the install as its own visible step.

Runtime pinning

devEngines.runtime.version is set to the exact 26.13.0 (with onFail: "warn", advisory only). Consequences:

  • CI installs the exact Node the dependency tree was validated against — reproducible, and runtime changes become explicit one-line diffs.
  • Trade-off accepted: Node security patches in later 26.x minors require a deliberate bump here.
  • .nvmrc (present since the repo's first commit, stale at 20) corrected to 26.13.0 so local nvm users land on the same runtime.

Also included

  • createBumpBranch.cjs: changeset detection now ignores README.md (pre-existing changeset dirs ship one).
  • README updates for the new toolchain.

Bump packageManager pin from 10.13.1 to 10.34.9 (latest pnpm 10.x).
Verified with pnpm install --frozen-lockfile and the full pnpm ci
gate (build, lint, test, webpack).

pnpm 12.x (the absolute latest) rewrites pnpm-lock.yaml into a
two-document stream (env document recording the pnpm pin), which nx
21.3.0 cannot parse; deferring until nx is updated.
pnpm: bump packageManager pin 10.34.9 -> 12.18.0. pnpm 12 records
the pinned package manager in a new env document at the top of
pnpm-lock.yaml (two-document YAML stream). pnpm-workspace.yaml
onlyBuiltDependencies is rewritten to the new allowBuilds format.

nx: bump 21.3.0 -> 24.0.5, whose lockfile parser handles the
two-document pnpm 12 lockfile format (21.x does not).

Verified: pnpm install (frozen and non-frozen), pnpm nx show
projects, and the full pnpm run ci gate (build, lint, test,
webpack).
pnpm/action-setup@v3 with an explicit version input overrides the
packageManager field, so CI was still running pnpm 9/10 instead of
the pinned 12.18.0. pnpm 9 cannot parse the two-document pnpm 12
lockfile and node 20 cannot run pnpm 12, which would have broken the
publish workflow.

- Drop the version inputs in ci.yml, release-github.yml, and
  publish-npm.yml so the pnpm version comes from packageManager
- Bump the publish job's node-version 20 -> 22
- engines.node: >=22 -> >=26
- All four workflow jobs: node-version 22 -> 26
- README prerequisites: currently 22 -> currently 26

Verified with the full pnpm run ci gate on Node v26.13.0.
- Mark Chunk 4 (nx 21 -> 24) complete; it was pulled forward as a
  prerequisite of the pnpm 12 bump (two-document lockfile)
- Record pre-chunk toolchain work in the Progress log: pnpm 12.18.0,
  engines, workflow pnpm/node pins, README
- Replace 'pnpm ci' with 'pnpm run ci' throughout: pnpm 11+ has a
  built-in 'pnpm ci' that shadows the repo's ci script
- Note deferred pnpm 11+ behaviors (minimumReleaseAge,
  verifyDepsBeforeRun, stale reserved-ci comments)
nx 24 rewrote the config on first run: 2-space formatting, expanded
arrays, and an explicit analytics: false. Semantics unchanged.
….112, eslint plugins (chunk 1/6)

- react/react-dom ^19.1.0 -> ^19.3.1 (examples)
- @types/react, @types/react-dom -> ^19.3.0 (examples)
- jest, @jest/globals ^30.0.4 -> ^30.5.2 (examples, packages 1+2)
- html-webpack-plugin ^5.6.3 -> ^5.6.8 (examples)
- ts-loader ^9.5.2 -> ^9.6.2 (examples)
- webpack ^5.100.0 -> ^5.112.2 (examples)
- @stylistic/eslint-plugin ^5.2.0 -> ^5.10.0 (eslint-config-shared)
- typescript-eslint ^8.37.0 -> ^8.72.1 (eslint-config-shared)

jest 30.5 pulls in @parcel/watcher (native build script via
jest-haste-map); added it to allowBuilds in pnpm-workspace.yaml.
The deprecated eslint@9 warning is expected — Chunk 2 moves it to 10.

Verified: pnpm install clean, full pnpm run ci gate green (10/10).
…n-perfectionist 5.13 (chunk 2/6)

- eslint ^9.31.0 -> ^10.14.0 in examples, packages/package1, packages/package2
- @eslint/js ^9.31.0 -> ^10.0.1 in eslint-config-shared
- eslint-plugin-perfectionist ^4.15.0 -> ^5.13.0 in eslint-config-shared
  (v5 is ESM-only; no deprecated options used by our config, verified)
- add eslint ^10.14.0 as devDependency of eslint-config-shared so its
  @eslint/js peer resolves in-package
- react.mjs: react version setting "detect" -> "19.x". Detection calls
  an API removed in ESLint 10 and crashes react/display-name loading on
  eslint-plugin-react 7.37.5 (jsx-eslint/eslint-plugin-react#3970); an
  explicit version bypasses the broken path. Bump with react major.

Known accepted exception: eslint-plugin-react 7.37.5 peer range caps at
eslint ^9.7 (no 10-supporting release yet; upstream PR #4022 pending),
so pnpm reports one unmet-peer warning in eslint-config-shared. Verified
empirically that all enabled react rules load and lint correctly under
ESLint 10 once the detect path is avoided.
…6.1.0 (chunk 3/6)

- webpack-cli ^6.0.1 -> ^7.3.1, webpack-dev-server ^5.2.2 -> ^6.1.0 (examples)
- start script: "webpack-dev-server" -> "webpack serve". dev-server v6
  removed its CLI (its bin now only delegates to webpack-cli serve); the
  canonical invocation is "webpack serve", which also drives dev-server 6
  as a compiler plugin (webpack-cli 7.3.0+).

No webpack.config.js changes needed: no devServer section, no removed
options (proxy bypass/sockjs/spdy) in use. Verified: build output
byte-identical to the v6-cli/v5-dev-server build, dev server boots in
~3s with live reload working, full gate green.
v3 is ESM-only and changes 'changeset version' to exit 1 when no
unreleased changesets are pending (v2 was a silent no-op). Since exit 1
is also the CLI's generic failure code, the release workflow now fails
early with a clear message by checking for changeset files in
.changeset/ before creating the bump branch, rather than interpreting
the exit code (upstream's recommended gate is simply: non-zero means
'nothing was versioned, do not proceed').

Also points the .changeset/config.json $schema at @changesets/config
4.0.1, the version v3 actually validates against.
6.0.3 is the newest single-version compiler supported by the toolchain:
typescript-eslint 8.72.1 peers typescript <6.1.0, and ts-loader 9.6.2 needs
the JS API that the TS 7.0 native line does not ship.

- tsconfig-shared: removed allowSyntheticDefaultImports/esModuleInterop
  false — an error as of TS 6.0 (TS5107); both now default to true.
- project tsconfigs: added rootDir ./src — TS 6.0's rootDir default is ./,
  which would shift emit to built/src/... and break main/types.
- Build output verified byte-identical to the 5.8.3 baseline in a dry run
  before applying.

The TS 7.0 side-by-side setup (native tsc + @typescript/typescript6) is
documented in DEPENDENCY-UPDATE-PLAN.md as the follow-up once
ts-loader/typescript-eslint support the native line.
Plan for bumping the five workflow actions to their newest majors
(checkout v7, setup-node v7, pnpm/action-setup v6,
create-github-app-token v3, github-script v9), ordered simplest first.
Independent of the deps/update-to-latest branch.
Per user decision: considering the official successor action pnpm/setup
is in scope for this same effort/branch, after all version bumps are
complete. Documented as a decision-gated chunk with background,
evaluation steps, adoption mechanics (install: false, devEngines.runtime,
registry-url analysis for the publish job), and verification.
Pure version-string replacement in all 8 occurrences (ci.yml ×1,
release-github.yml ×5, publish-npm.yml ×2). The only input used is
ref (unchanged in v7); the repo uses no pull_request_target /
workflow_run triggers, so v7's fork-PR checkout block is N/A.
actionlint: identical to the recorded 2-finding baseline.
…nly/no-push constraint

Per user: no pushing for the duration of the effort — per-chunk
verification is local (scratch dry-run + actionlint vs. recorded
baseline); PR CI / dry-run checks are deferred to when the branch
is pushed.
Pure version-string replacement in all 4 occurrences (ci.yml ×1,
release-github.yml ×1, publish-npm.yml ×2). No inputs are passed;
the action resolves pnpm 12.18.0 from the packageManager pin via
its v6 bootstrap (npm ci of pnpm 11.19.0, then self-update to the
pinned version). Defaults are benign: run_install null, cache false,
standalone false. actionlint: identical to the recorded baseline.
Pure version-string replacement in all 4 occurrences (ci.yml ×1,
release-github.yml ×1, publish-npm.yml ×2). Inputs in use:
node-version (all) and registry-url (publish job) — both unchanged in
v7. v5's auto-caching is inert (pnpm packageManager, not npm, and no
cache input); v7's dummy NODE_AUTH_TOKEN removal is inert (auth is set
explicitly per-step from secrets.NPM_AUTH_TOKEN). actionlint: identical
to the recorded baseline.
… (chunk 4/6)

v1 → v3.3.0 (latest release; v3 major tag points at the same commit).
Pinned exactly rather than to the major tag because actionlint 1.7.12
serves stale v3.0.0 metadata for @V3 (the tag was moved to v3.3.0 on
2026-10-12), which would report 12 false findings for client-id.

app-id → client-id at all 6 call sites: v3.1.0 soft-deprecated app-id
in favor of client-id (GitHub's UI rename of App ID to Client ID).
Verified in the v3.3.0 source that both map to the identical octokit
appId field — the repo variable CHUMPCHIEF_RELEASE_BOT_APP_ID is
unchanged. No other behavior change: token revocation (post hook)
already existed at v1.12; snake_case removal (v2) N/A (we use
kebab-case). actionlint: identical to the 2-finding baseline.
Inputs in use (script, github-token, result-encoding) and the result
output are byte-identical between the v7 and v9 manifests; runtime
moves node20 → node24. v9's breaking change (ESM-only @actions/github,
getOctokit as injected function param) does not affect this repo:
all 5 external scripts use only the injected {github, context, core,
exec} params, and the 6 inline require() calls load local .cjs files
or node builtins only. No getOctokit redeclarations anywhere.
@v9 resolves to v9.0.0, the latest release. actionlint: identical to
the 2-finding baseline.
Keep the 4-space indent, inlined arrays, and trailing newline from
before the nx 24 rewrite. The only semantic addition from that
rewrite (analytics: false, which also suppresses the first-run
analytics prompt) is retained. nx does not rewrite the file on
normal runs, so the formatting is stable.
…hunk 7/7)

pnpm update (no args) re-resolved every locked package to the newest
version its parent's range allows. Direct-dependency ranges in
package.json are untouched.

pnpm audit: 39 findings (24 high / 11 moderate / 4 low) -> 3
(1 low / 2 moderate). The residue is unfixable in-repo:

- glob 10.5.0 (moderate) — parent test-exclude@7 (jest 30.5.2
  chain) declares the 10.x line; fix is 14.0.2
- minimatch 10.2.5 (moderate) — nx@24.0.5 declares the 10.x line;
  fix is 11.0.1
- deepmerge 4.3.1 (low, via jest-config) — no patched version
  published (GHSA-gcqx-w48m-w2h4)

Note: pnpm 12's update also rewrote devEngines.runtime.version from
the deliberate floating "26" to the exact "26.13.0"; reverted to
keep the latest-LTS-minor policy.

Full CI gate green (build/lint/test/webpack x 3 projects).
devEngines.runtime.version: "26" -> "26.13.0". pnpm/setup reads
devEngines.runtime automatically (manifest takes precedence over
.node-version), so CI now installs the exact Node version the
dependency tree was validated against, with no workflow changes.

onFail stays "warn": the pin is a reproducibility selector and
documentation, not a hard gate.

.node-version updated to match so local nvm/fnm users land on the
same runtime instead of collecting a warn annotation on every
other 26.x minor.

Trade-off accepted: Node security patches in later 26.x minors will
now require a deliberate one-line bump here instead of being picked
up automatically.
.nvmrc has existed since the repo's first commit (7eb2ddc) but said
"20" — stale and unnoticed, since CI reads devEngines and nvm
users only hit it via an explicit "nvm use".

nvm reads .nvmrc and nothing else (no .node-version, no
devEngines), so .nvmrc is the filename that matters for local nvm
users. fnm reads either; pnpm/setup's version-file fallback checks
.nvmrc second (never reached in CI — the devEngines manifest takes
precedence).

Bump .nvmrc to 26.13.0 to match devEngines.runtime.version and
delete the .node-version this branch added — redundant once
.nvmrc is current.
@ChumpChief
ChumpChief merged commit c11311e into ChumpChief:main Nov 8, 2026
1 check passed
@ChumpChief-bot
ChumpChief-bot deleted the deps/update-to-latest branch November 8, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants