fix: account for scroll offsets in downscaled screenshots - #2685
Open
ddussi wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2684
When a screenshot size limit causes downscaling, viewport and element screenshots on a scrolled page capture the wrong region because their clip coordinates omit the page scroll offset.
Summary
getSourceBox()by reading scroll offsets alongside the existing dimensions and device pixel ratio. Add the main page offset to element bounding boxes; keep full-page boxes at the document origin.Testing
All three regressions fail against unmodified source and pass with the fix.
npm run test -- --test-concurrency=2: 897 passed, 3 skipped, 0 failed.npm run check-formatandnpm run gen: pass; no generated-file changes.NODE_OPTIONS=--max_old_space_size=4096 npm run bundleandnpm run test:notices:no-build: pass.Separate clipped-capture problems with pinch zoom and RTL layouts also reproduce before this patch and are not addressed here.