feat: report pages opened by input actions - #2679
Open
lisa0314 wants to merge 1 commit into
Open
Conversation
Author
|
PTAL. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #367
When an input action opens one or more pages, capture the source page's Puppeteer
popupevents and report only those newly opened pages in the action response.Each new page is listed under
## New pageswith its MCP page ID, title, and URL. The same entries are exposed throughstructuredContent.newPages. Pages that were already open are not included, and the complete page list is not enabled implicitly.Tests cover a single popup with an unrelated pre-existing page, multiple popups in event order with distinct MCP page IDs, and popup listener cleanup.
Testing
npm run buildnpm run check-formatnpm run test -- tests/utils/WaitForHelper.test.ts tests/tools/input.test.tsnpm run test -- tests/tools/extensions.test.ts tests/tools/pages.test.ts