fix: treat timeout 0 as the default wait, not unlimited - #2647
Open
gyanu2507 wants to merge 2 commits into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
wolfib
self-requested a review
September 3, 2026 10:43
The schema text says 0 uses the default timeout, but `value && value <= 0` is falsy for 0, so Puppeteer got timeout: 0 and waited forever.
gyanu2507
force-pushed
the
fix/timeout-zero-means-default
branch
from
September 4, 2026 05:23
591af93 to
ad23966
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timeoutSchemadocuments thattimeout: 0uses the default wait. The transform usedvalue && value <= 0, which is falsy for0, so the number0was passed through to Puppeteer. In Puppeteer,timeout: 0means wait forever.Agents that pass
0expecting the normal default can hangnavigate_page/new_pageon a stuck load.Test plan
timeout: 0and-1parse toundefinedtimeout: 500stays500