Skip to content

Remove Fullscreen Optimizations disable tweak - #5000

Open
mewclouds wants to merge 1 commit into
ChrisTitusTech:mainfrom
mewclouds:chore/remove-fullscreen-optimizations-tweak
Open

Remove Fullscreen Optimizations disable tweak#5000
mewclouds wants to merge 1 commit into
ChrisTitusTech:mainfrom
mewclouds:chore/remove-fullscreen-optimizations-tweak

Conversation

@mewclouds

@mewclouds mewclouds commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Type of Change

  • Refactor

Description

Removes the WPFTweaksDisableFSO tweak from config/tweaks.json. The tweak disables fullscreen optimizations globally across all games, which causes more issues than it solves. Users experiencing game-specific problems can still use the per-executable compatibility option instead.

Acceptance Criteria

  • Remove WPFTweaksDisableFSO from config/tweaks.json
  • Remove any remaining preset or UI references to that tweak, if present
  • Do not replace it with another system-wide Fullscreen Optimizations registry override
  • Ensure generated tweak documentation no longer includes the removed entry
  • Verify Compile.ps1 and the relevant configuration/Pester tests pass

Issue related to PR

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ec9f33ee-fce2-438b-aee0-a11d56990cb8

📥 Commits

Reviewing files that changed from the base of the PR and between 3f1850f and ac2b5d5.

📒 Files selected for processing (1)
  • config/tweaks.json
💤 Files with no reviewable changes (1)
  • config/tweaks.json

Included review availability: Your plan includes up to 10 reviews per rolling hour; 9 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Removed the tweak that disabled fullscreen optimizations, allowing the operating system’s default fullscreen behavior to remain enabled.

Walkthrough

The pull request removes WPFTweaksDisableFSO from config/tweaks.json, including its per-user registry override that disabled fullscreen optimizations.

Changes

Fullscreen optimization cleanup

Layer / File(s) Summary
Remove fullscreen optimization configuration
config/tweaks.json
Removes the WPFTweaksDisableFSO tweak, its registry change, and its metadata.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to ac2b5

This localized change removes the global fullscreen-optimization disable setting while preserving per-executable compatibility options; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: christitustech

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive The configuration entry is removed, but the summary does not verify references, generated documentation, or required test results. Provide evidence that no preset, UI, or generated documentation references remain and that Compile.ps1 and relevant Pester tests pass.
✅ Passed checks (4 passed)
Check name Status Explanation
Out of Scope Changes check ✅ Passed The only reported change removes the targeted configuration entry and aligns with the linked issue objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly and concisely describes the removal of the system-wide Fullscreen Optimizations disable tweak.
Description check ✅ Passed The description directly explains the removed tweak, its rationale, acceptance criteria, and expected related changes.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mewclouds

mewclouds commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai check the body again, I added the acceptance criteria from #4998. All actionable items have been marked as verified.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo '--- Pull request body, changed files, and checks ---'
gh pr view 5000 --repo ChrisTitusTech/winutil --json body,files,statusCheckRollup \
  --jq '{body, changedFiles: [.files[].path], checks: [.statusCheckRollup[] | {name, status, conclusion}]}'

echo
echo '--- Candidate configuration and documentation files ---'
fd -a '^(tweaks\.json|.*tweak.*\.(md|json)|.*documentation.*\.(md|json))$' . \
  -E .git -E node_modules -E dist -E build | sort

echo
echo '--- Remaining identifier references (excluding Git metadata) ---'
rg -n -i -C 2 'WPFTweaksDisableFSO' . \
  -g '!**/.git/**' -g '!**/node_modules/**' -g '!**/dist/**' -g '!**/build/**' || true

echo
echo '--- Fullscreen Optimization / registry override candidates ---'
rg -n -i -C 3 '(fullscreen[[:space:]-]*optimizations|GameDVR_FSEBehavior|DisableFullscreenOptimizations|~[[:space:]]*DISABLEDXMAXIMIZEDWINDOWEDMODE)' . \
  -g '!**/.git/**' -g '!**/node_modules/**' -g '!**/dist/**' -g '!**/build/**' || true

echo
echo '--- Current branch diff summary and relevant diff ---'
git diff --stat HEAD^ HEAD
git diff HEAD^ HEAD -- config/tweaks.json 2>/dev/null || true

Length of output: 6387


@mewclouds, I rechecked the acceptance criteria.

config/tweaks.json correctly removes WPFTweaksDisableFSO. The removed entry contained the system-wide GameDVR_DXGIHonorFSEWindowsCompatible override. The PR does not add a replacement override. The Compile-and-Check workflow passed.

One acceptance criterion is still not met. docs/src/content/docs/code-reference/tweaks/z--Advanced-Tweaks---CAUTION/DisableFSO.mdx remains in the branch. It still documents WPFTweaksDisableFSO and its registry override. The PR changes only config/tweaks.json, so the documentation is not regenerated or removed.

Please remove the stale documentation file or run the documentation generation step and include its output.

You are interacting with an AI system.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo '== Pull request metadata and body =='
gh pr view 5000 --repo ChrisTitusTech/winutil --json title,body,changedFiles,files,url

echo
echo '== Changed files =='
git diff --name-status HEAD^ HEAD

echo
echo '== Removed tweak references in tracked source =='
rg -n -i -C 2 'WPFTweaksDisableFSO|DisableFSO|Fullscreen Optimizations|FullScreen Optimizations' \
  -g '!**/.git/**' .

echo
echo '== Fullscreen-optimization registry override indicators =='
rg -n -i -C 3 'GameDVR_FSEBehavior|GameDVR_HonorUserFSEBehaviorMode|GameDVR_DXGIHonorFSEWindowsCompatible|~\s*DISABLEDXMAXIMIZEDWINDOWEDMODE|DISABLEDXMAXIMIZEDWINDOWEDMODE' \
  -g '!**/.git/**' .

Length of output: 4286


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo '== config/tweaks.json diff =='
git diff --unified=20 HEAD^ HEAD -- config/tweaks.json

echo
echo '== Tracked status of stale documentation =='
git ls-files --error-unmatch 'docs/src/content/docs/code-reference/tweaks/z--Advanced-Tweaks---CAUTION/DisableFSO.mdx'
git status --short -- 'docs/src/content/docs/code-reference/tweaks/z--Advanced-Tweaks---CAUTION/DisableFSO.mdx'

echo
echo '== Pull request checks =='
gh pr checks 5000 --repo ChrisTitusTech/winutil --required || true

Length of output: 3466


@mewclouds I rechecked the acceptance criteria.

config/tweaks.json correctly removes WPFTweaksDisableFSO. The removed entry includes the system-wide GameDVR_DXGIHonorFSEWindowsCompatible override.

Two checked criteria are not verified by the current PR state:

  • Generated documentation still includes the removed tweak at docs/src/content/docs/code-reference/tweaks/z--Advanced-Tweaks---CAUTION/DisableFSO.mdx.
  • GitHub reports no required checks for this branch. Therefore, I cannot verify that Compile.ps1 and the relevant configuration/Pester tests passed.

The documentation file must be regenerated or removed before the documentation acceptance criterion is complete.

You are interacting with an AI system.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ac2b5d52a0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread config/tweaks.json
Comment thread config/tweaks.json
@mewclouds

Copy link
Copy Markdown
Contributor Author

@coderabbitai the documentation is generated automatically after the PR is merged. I checked locally and after running the devdocs-generator the DisableFSO.mdx was gone. No action needed from my end.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Tip

For best results, initiate chat on the files or code changes.

@mewclouds, thanks for the clarification. The generated documentation updates after merge, and your local devdocs-generator verification confirms that DisableFSO.mdx is removed. No documentation change is required in this PR.


✏️ Learnings added
Learnt from: mewclouds
URL: https://github.com/ChrisTitusTech/winutil/pull/5000

Timestamp: 2026-08-18T02:04:03.034Z
Learning: In ChrisTitusTech/winutil, generated tweak documentation is updated automatically after a pull request merges. When a tweak is removed from `config/tweaks.json`, `devdocs-generator` removes its corresponding generated `.mdx` file, so generated documentation files do not need to be changed in the source pull request.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

You are interacting with an AI system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove FullScreen Optimizations Tweak

1 participant