Remove Fullscreen Optimizations disable tweak - #5000
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan includes up to 10 reviews per rolling hour; 9 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe pull request removes ChangesFullscreen optimization cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized change removes the global fullscreen-optimization disable setting while preserving per-executable compatibility options; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai check the body again, I added the acceptance criteria from #4998. All actionable items have been marked as verified. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '--- Pull request body, changed files, and checks ---'
gh pr view 5000 --repo ChrisTitusTech/winutil --json body,files,statusCheckRollup \
--jq '{body, changedFiles: [.files[].path], checks: [.statusCheckRollup[] | {name, status, conclusion}]}'
echo
echo '--- Candidate configuration and documentation files ---'
fd -a '^(tweaks\.json|.*tweak.*\.(md|json)|.*documentation.*\.(md|json))$' . \
-E .git -E node_modules -E dist -E build | sort
echo
echo '--- Remaining identifier references (excluding Git metadata) ---'
rg -n -i -C 2 'WPFTweaksDisableFSO' . \
-g '!**/.git/**' -g '!**/node_modules/**' -g '!**/dist/**' -g '!**/build/**' || true
echo
echo '--- Fullscreen Optimization / registry override candidates ---'
rg -n -i -C 3 '(fullscreen[[:space:]-]*optimizations|GameDVR_FSEBehavior|DisableFullscreenOptimizations|~[[:space:]]*DISABLEDXMAXIMIZEDWINDOWEDMODE)' . \
-g '!**/.git/**' -g '!**/node_modules/**' -g '!**/dist/**' -g '!**/build/**' || true
echo
echo '--- Current branch diff summary and relevant diff ---'
git diff --stat HEAD^ HEAD
git diff HEAD^ HEAD -- config/tweaks.json 2>/dev/null || trueLength of output: 6387
One acceptance criterion is still not met. Please remove the stale documentation file or run the documentation generation step and include its output. You are interacting with an AI system. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '== Pull request metadata and body =='
gh pr view 5000 --repo ChrisTitusTech/winutil --json title,body,changedFiles,files,url
echo
echo '== Changed files =='
git diff --name-status HEAD^ HEAD
echo
echo '== Removed tweak references in tracked source =='
rg -n -i -C 2 'WPFTweaksDisableFSO|DisableFSO|Fullscreen Optimizations|FullScreen Optimizations' \
-g '!**/.git/**' .
echo
echo '== Fullscreen-optimization registry override indicators =='
rg -n -i -C 3 'GameDVR_FSEBehavior|GameDVR_HonorUserFSEBehaviorMode|GameDVR_DXGIHonorFSEWindowsCompatible|~\s*DISABLEDXMAXIMIZEDWINDOWEDMODE|DISABLEDXMAXIMIZEDWINDOWEDMODE' \
-g '!**/.git/**' .Length of output: 4286 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '== config/tweaks.json diff =='
git diff --unified=20 HEAD^ HEAD -- config/tweaks.json
echo
echo '== Tracked status of stale documentation =='
git ls-files --error-unmatch 'docs/src/content/docs/code-reference/tweaks/z--Advanced-Tweaks---CAUTION/DisableFSO.mdx'
git status --short -- 'docs/src/content/docs/code-reference/tweaks/z--Advanced-Tweaks---CAUTION/DisableFSO.mdx'
echo
echo '== Pull request checks =='
gh pr checks 5000 --repo ChrisTitusTech/winutil --required || trueLength of output: 3466
Two checked criteria are not verified by the current PR state:
The documentation file must be regenerated or removed before the documentation acceptance criterion is complete. You are interacting with an AI system. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac2b5d52a0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@coderabbitai the documentation is generated automatically after the PR is merged. I checked locally and after running the devdocs-generator the DisableFSO.mdx was gone. No action needed from my end. |
|
Tip For best results, initiate chat on the files or code changes.
✏️ Learnings added
You are interacting with an AI system. |
Type of Change
Description
Removes the WPFTweaksDisableFSO tweak from config/tweaks.json. The tweak disables fullscreen optimizations globally across all games, which causes more issues than it solves. Users experiencing game-specific problems can still use the per-executable compatibility option instead.
Acceptance Criteria
Issue related to PR