Skip to content

Modernize ToDataTable Package and Update Dependencies - #6

Open
danielmallott wants to merge 2 commits into
ChrisHodges:masterfrom
danielmallott:modernize-package
Open

Modernize ToDataTable Package and Update Dependencies#6
danielmallott wants to merge 2 commits into
ChrisHodges:masterfrom
danielmallott:modernize-package

Conversation

@danielmallott

Copy link
Copy Markdown

I use this package in a project I have (https://github.com/danielmallott/lego-data-set-loader), and Snyk has been bothering me about the security issues with System.Data.SqlClient, so I took it upon myself to make some version updates.

This PR accomplishes the following:

  • Updates ToDataTable.csproj to target NetStandard 2.0, in line with Microsoft guidance on building libraries
  • Updates other projects to target Net 10.0
  • Replaces System.Data.SqlClient with Microsoft.Data.SqlClient, in line with Microsoft guidance
  • Removes unused HyperDescriptor packages, which targeted only .NET Framework
  • Updates other packages to most recent version available
  • Migrates to slnx solution file format
  • Updates ToDataTable.Benchmarks to specifically reference the Release version of its dependence projects
  • Updates Nuget package version to 1.0.0, to reflect targeting update

The unit tests and benchmark tests both pass.

@danielmallott

Copy link
Copy Markdown
Author

@ChrisHodges - any changes or updates I should make to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant