Repository navigation
chore(ci): bootstrap bashunit via bashdep and tighten Makefile DX - #67
Merged
Merged
Conversation
- Add .bashdep pinning bashunit 0.45.0 with #sha256=; install-dependencies.sh now installs it with bashdep itself instead of a remote installer. - make test installs bashunit on first run and when .bashdep changes. - make lists targets from ## comments; mistyped targets now fail instead of being swallowed by the release catch-all. - pre_commit/install links the hook so bin/pre-commit edits apply. - Drop unused OS detection and dead variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A fresh clone needed
make depsbeforemake testworked.make tsetexited 0 and did nothing.make depspulled bashunit through a remote installer on every run, in a repo whose whole job is installing bash deps.What
.bashdeppins bashunit 0.45.0 with#sha256=.install-dependencies.shinstalls it with bashdep itself. Re-runs skip.make testinstalls bashunit on first run, and again when.bashdepchanges.makelists targets from##comments in the Makefile, so help can't drift.releaseandrelease/dry-run.make pre_commit/installlinks the hook instead of copying it, and resolves the hooks dir withgit rev-parse --git-path hooks..bashdep.To bump bashunit now, edit the URL and
#sha256=in.bashdep. TheBASHUNIT_VERSIONoverride is gone.Test plan
rm -rf lib && make test: installs bashunit, 252 tests passmake test: no reinstallmake tset:No rule to make target, exit 2make release/dry-run 9.9.9still passes the version through/bin/bash install-dependencies.shon bash 3.2make checkgreen