Repository navigation
Conversation
Closed
The keyword moves from RobotmkLibrary/__init__.py to RobotmkLibrary/keyword_monitoring/__init__.py; the package re-exports it, so Library RobotmkLibrary keeps working, and Library RobotmkLibrary.keyword_monitoring imports the keyword monitoring keywords alone. The README documents the keyword. robotframework becomes a dependency, and an integration test pins the keyword list of the package through libdoc. pytest joins the dev tools and the workflow; mypy checks the tests too, with calls into the untyped robot package excluded from disallow_untyped_calls and the Any-typed values it returns tolerated in tests.
jherbel
previously approved these changes
Nov 19, 2026
| requires-python = ">=3.11" | ||
| dependencies = [] | ||
| dependencies = [ | ||
| "robotframework>=7.5.1", |
Collaborator
There was a problem hiding this comment.
Right now, we only need this for testing, so we could add this as a dev dependency. I also checked the next PR, which implements the listener. Also there, we don't need it in production code. On the other hand, there is no point in using this package without this dependency and the fact that we use the V3 listener API certainly imposes some restriction. So I am fine with this, but again, please make sure Simon Meggle is as well.
Collaborator
Author
There was a problem hiding this comment.
I clarify with him. Sadly this dependency is somewhat implicit but real but I am also not super happy with it.
jherbel
approved these changes
Nov 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The keyword moves from RobotmkLibrary/init.py to
RobotmkLibrary/keyword_monitoring/init.py; the package re-exports
it, so Library RobotmkLibrary keeps working, and
Library RobotmkLibrary.keyword_monitoring imports the keyword
monitoring keywords alone. The README documents the keyword.
robotframework becomes a dependency, and an integration test pins the
keyword list of the package through libdoc. pytest joins the dev tools
and the workflow; mypy checks the tests too, with calls into the
untyped robot package excluded from disallow_untyped_calls and the
Any-typed values it returns tolerated in tests.