Skip to content

Turn the library into a package - #12

Open
crest42 wants to merge 1 commit into
python311from
package
Open

crest42 wants to merge 1 commit into
python311from
package

Conversation

@crest42

@crest42 crest42 commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

The keyword moves from RobotmkLibrary/init.py to
RobotmkLibrary/keyword_monitoring/init.py; the package re-exports
it, so Library RobotmkLibrary keeps working, and
Library RobotmkLibrary.keyword_monitoring imports the keyword
monitoring keywords alone. The README documents the keyword.

robotframework becomes a dependency, and an integration test pins the
keyword list of the package through libdoc. pytest joins the dev tools
and the workflow; mypy checks the tests too, with calls into the
untyped robot package excluded from disallow_untyped_calls and the
Any-typed values it returns tolerated in tests.

@crest42
crest42 added this pull request to stack #13 November 18, 2026 17:36
@crest42 crest42 mentioned this pull request Nov 18, 2026
@crest42
crest42 requested a review from jherbel November 18, 2026 17:43
The keyword moves from RobotmkLibrary/__init__.py to
RobotmkLibrary/keyword_monitoring/__init__.py; the package re-exports
it, so Library RobotmkLibrary keeps working, and
Library RobotmkLibrary.keyword_monitoring imports the keyword
monitoring keywords alone. The README documents the keyword.

robotframework becomes a dependency, and an integration test pins the
keyword list of the package through libdoc. pytest joins the dev tools
and the workflow; mypy checks the tests too, with calls into the
untyped robot package excluded from disallow_untyped_calls and the
Any-typed values it returns tolerated in tests.
jherbel
jherbel previously approved these changes Nov 19, 2026
Comment thread pyproject.toml
requires-python = ">=3.11"
dependencies = []
dependencies = [
"robotframework>=7.5.1",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, we only need this for testing, so we could add this as a dev dependency. I also checked the next PR, which implements the listener. Also there, we don't need it in production code. On the other hand, there is no point in using this package without this dependency and the fact that we use the V3 listener API certainly imposes some restriction. So I am fine with this, but again, please make sure Simon Meggle is as well.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I clarify with him. Sadly this dependency is somewhat implicit but real but I am also not super happy with it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants