Skip to content

Add --severity-filter flag to realtime scan commands (AST-193900) - #1620

Open
cx-anurag-dalke wants to merge 3 commits into
stagingfrom
feature/AST-193900
Open

cx-anurag-dalke wants to merge 3 commits into
stagingfrom
feature/AST-193900

Conversation

@cx-anurag-dalke

Copy link
Copy Markdown
Contributor

By submitting this pull request, you agree to the terms within the Checkmarx Code of Conduct. Please review the contributing guidelines for guidance on creating high-quality pull requests.

Description

Adds an optional --severity-filter flag to the five Dev Assist realtime scan commands so IDE plugins can ask the CLI to return only findings of selected severities:

cx scan asca -s src/App.java --asca-latest-version --severity-filter "critical,high"
cx scan oss-realtime -s package.json --severity-filter "critical,high"
cx scan iac-realtime -s deployment.yaml --engine podman --severity-filter "critical,high"
cx scan containers-realtime -s Dockerfile --severity-filter "critical,high"
cx scan secrets-realtime -s config.env --severity-filter "critical,high"

Behaviour

  • Comma-separated, case-insensitive. Accepted values: critical, high, medium, low, info.
  • Omitted or empty flag → no filtering, all severities are returned. Existing callers are unaffected.
  • Any unknown token fails fast (before the scan runs) with a RealtimeEngineError that names each bad token and lists the accepted values.
  • Filtering runs client side in the command layer after the service returns. Service method signatures are unchanged.
  • oss-realtime and containers-realtime: the filter trims each package's / image's Vulnerabilities list. Entries are kept even when the list becomes empty (one entry per manifest item is preserved), and Malicious entries are always kept untouched since they carry no severity.
  • asca, iac-realtime, secrets-realtime: findings whose severity is not in the filter are dropped.
  • Agent-hooks guardrails (cx_severity_threshold) are not touched.

Implementation

  • New shared parser/filter type in internal/services/realtimeengine/severity.go (ParseSeverityFilter, SeverityFilter.Allows).
  • New flag constants SeverityFilterFlag / SeverityFilterFlagUsage in internal/params/flags.go.
  • Per-engine filter helpers next to each realtime service; wired into the five Run*Command handlers in internal/commands/.
  • Help text and examples updated for all five subcommands in scan.go.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Related Issues

Checklist

  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the CLI help for new/changed functionality in this PR (if applicable)
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

Additional Notes

  • Unit tests added for the shared parser and for each engine's filter (severity-filter_test.go in each package, severity_test.go for the parser). Integration tests added in test/integration/severity-filter_test.go; these were not run locally and will run in CI.
  • The flag is additive, so downstream wrappers (Java/JS) and IDE plugins can adopt it after this ships without any breaking change. The IDE owns the default severity set and is expected to always pass an explicit list.

🤖 Generated with Claude Code

cx-sumit-morchhale and others added 2 commits November 12, 2026 14:45
* Honour the VS Code Checkmarx Self-Healing setting in Copilot agent hooks (AST-180812) (#1603)

* AST-180812 - Detect VS Code Copilot CLI sessions from GITHUB_COPILOT_INTEGRATION_ID (#1604)

* Feature/ast 180812 vscode copilot cli host (#1607)

* Update brotli dependency to v1.2.7 (AST-189161) (#1610)

* Update github.com/andybalholm/brotli from v1.2.0 to v1.2.7 (AST-189161)

Indirect dependency pulled in via anchore/syft -> anchore/archiver.
No API removals; archiver only uses NewWriterLevel/NewReader, which are unchanged.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Update Docker base image checkmarx/bash:5.3 to latest digest (AST-189161)

Bumps the SHA256-pinned base image to the 5.3-r14 build pushed on 2026-11-04.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Replace .trivyignore entries with current binary findings (AST-189161)

Ignore GO-2026-5932 (x/crypto/openpgp via helm provenance), CVE-2026-78661 and
CVE-2026-97045 (x/net/html via syft Maven cataloger). Remove the previous Wolfi
base-image and syft/docker entries, which no longer apply.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Restore syft and docker entries in .trivyignore (AST-189161)

CVE-2026-33481 (syft temp cleanup) and CVE-2026-33997 (moby plugin privilege
bypass) are still reported against the binary. Neither has an adoptable fix:
syft >= 1.42.3 reintroduces the binary-size regression reverted in AST-188320
and docker/docker has no 29.x release on its module path. Justifications and
reachability analysis are recorded in the file.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Bump golang.org/x/net to v0.62.0 and trim .trivyignore (AST-189161)

Bump the indirect golang.org/x/net dependency to v0.62.0, which fixes
CVE-2026-78661 and CVE-2026-97045, so their ignore entries are dropped.
Keep only the ignores that cannot be fixed directly: GO-2026-5932
(x/crypto openpgp, via helm), CVE-2026-33481 (syft) and CVE-2026-33997
(docker).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Co-authored-by: atishj99 <atish.jadhav@checkmarx.com>

* revret exclude git config changes (#1609)

Co-authored-by: Aniket Shinde <aniket.shinde@checkmarx.com>

* Use self-repository syntax for reusable workflow in nightly-parallel (AST-189161)

Replace `uses: ./.github/workflows/ci-tests.yml` with the `$/` form to
satisfy the zizmor `self-repository` audit (added in zizmor v1.30.0).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Handle missing feature flags(AST-188568) (#1613)

* Handle missing feature flags gracefully (code 100 response)

When the API returns a 404 with error code 100 and message
"flag with the given name is not found", return a disabled flag
model instead of nil to prevent nil pointer dereference panics
in calling code. Missing flags are treated as enabled (default)
to ensure safe feature flag fallback behavior.

Fixes panic: runtime error: invalid memory address or nil pointer dereference
when GetSpecificFlag is called and the flag doesn't exist on the server.

* Refactor: use existing WebError struct instead of inline type

Replace inline error response struct with the existing WebError struct
from ast.go for consistency with the rest of the codebase. This improves
maintainability and follows the established pattern in wrappers like
bfl-http.go and codebashing-http.go.

* handle remove ff

* Remove INCREASE_FILE_UPLOAD_LIMIT flag - now always enabled for large files

Removed the INCREASE_FILE_UPLOAD_LIMIT feature flag that controlled multipart
uploads. The flag is now permanently enabled - files > 5GB always use multipart
upload, smaller files use single upload. This simplifies the code by removing
the flag check and associated tests.

Changes:
- Removed flag constant from feature-flags.go
- Updated scan.go to always check file size (no flag check)
- Consolidated 5 tests to 3 tests (removed redundant flag-based tests)
- Behavior unchanged: multipart for >5GB, single for <=5GB

No regression - functionality preserved, code simplified.

* removed status code handling

* updated docker image

---------

Co-authored-by: Anurag Dalke <120229307+cx-anurag-dalke@users.noreply.github.com>

* Undo merge conflict resolution commit

This removes the problematic merge commit a1df4b1 that resolved
the Dockerfile conflict. Going back to the clean state before
that merge attempt.

All code is preserved - reverting to e3250aa state.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

* Ignore glibc CVE-2026-84243 and Go stdlib CVE-2026-97054 in Trivy

Both are newly disclosed. glibc comes from the checkmarx/bash base image
(fix in 2.44-r16, no rebuilt image yet); stdlib is fixed in Go 1.26.11.
Remove once the base image is rebuilt and the Go toolchain is bumped.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Rahul Pidde <206018639+cx-rahul-pidde@users.noreply.github.com>
Co-authored-by: Anurag Dalke <anurag.dalke@checkmarx.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Co-authored-by: atishj99 <atish.jadhav@checkmarx.com>
Co-authored-by: Aniket Shinde <aniket.shinde@checkmarx.com>
Co-authored-by: Anurag Dalke <120229307+cx-anurag-dalke@users.noreply.github.com>
Adds an optional, comma-separated --severity-filter flag to the five
Dev Assist realtime commands: asca, oss-realtime, iac-realtime,
containers-realtime and secrets-realtime. Accepted values are
critical, high, medium, low and info (case insensitive). When the flag
is omitted or empty, all severities are returned, so existing callers
are unaffected. Invalid tokens fail fast with a RealtimeEngineError
that lists the accepted values.

Filtering is applied client side in the command layer after the
service returns; service signatures are unchanged. For oss-realtime
and containers-realtime the filter trims each package/image's
vulnerability list and leaves malicious entries untouched, so
consumers still receive one entry per manifest item.

Includes unit tests for the shared parser and each engine's filter,
plus integration tests for the new flag.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@cx-anurag-dalke
cx-anurag-dalke requested a review from a team as a code owner November 19, 2026 12:06

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants