Skip to content

Handle missing feature flags(AST-188568) - #1613

Merged
cx-sumit-morchhale merged 6 commits into
stagingfrom
other/AST-0000-flagNotFoundHandle
Nov 11, 2026
Merged

cx-sumit-morchhale merged 6 commits into
stagingfrom
other/AST-0000-flagNotFoundHandle

Conversation

@cx-sumit-morchhale

Copy link
Copy Markdown
Contributor

Summary

Fixed panic when feature flags API returns 404 with error code 100. When a flag is not found, the function now returns a flag model with the name and enabled status instead of nil, preventing nil pointer dereference panics.

Changes

  • Modified GetSpecificFlag() to decode error response and check for code 100
  • When code 100 is detected ("flag with the given name is not found"), returns FeatureFlagResponseModel{Name: flagName, Status: true}
  • Missing flags are treated as enabled (safe default) to ensure features work unless explicitly disabled

Test plan

  • ✅ Build verified - no compilation errors
  • ✅ Fix prevents nil pointer dereference panic in calling code like scan.go:2569 and common.go:18
  • ✅ Graceful fallback - missing flags are enabled by default
  • ✅ No breaking changes to interface or existing functionality

Related issue

Fixes panic: runtime error: invalid memory address or nil pointer dereference

When the API returns a 404 with error code 100 and message
"flag with the given name is not found", return a disabled flag
model instead of nil to prevent nil pointer dereference panics
in calling code. Missing flags are treated as enabled (default)
to ensure safe feature flag fallback behavior.

Fixes panic: runtime error: invalid memory address or nil pointer dereference
when GetSpecificFlag is called and the flag doesn't exist on the server.
@cx-sumit-morchhale
cx-sumit-morchhale requested a review from a team as a code owner November 11, 2026 10:00
@cx-sumit-morchhale cx-sumit-morchhale changed the title Handle missing feature flags gracefully (code 100 response) Handle missing feature flags(AST-0000) Nov 11, 2026
Replace inline error response struct with the existing WebError struct
from ast.go for consistency with the rest of the codebase. This improves
maintainability and follows the established pattern in wrappers like
bfl-http.go and codebashing-http.go.
… files

Removed the INCREASE_FILE_UPLOAD_LIMIT feature flag that controlled multipart
uploads. The flag is now permanently enabled - files > 5GB always use multipart
upload, smaller files use single upload. This simplifies the code by removing
the flag check and associated tests.

Changes:
- Removed flag constant from feature-flags.go
- Updated scan.go to always check file size (no flag check)
- Consolidated 5 tests to 3 tests (removed redundant flag-based tests)
- Behavior unchanged: multipart for >5GB, single for <=5GB

No regression - functionality preserved, code simplified.
@cx-sumit-morchhale cx-sumit-morchhale changed the title Handle missing feature flags(AST-0000) Handle missing feature flags(AST-188568) Nov 11, 2026

@cx-anurag-dalke cx-anurag-dalke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@cx-amol-mane cx-amol-mane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cx-sumit-morchhale
cx-sumit-morchhale merged commit e3250aa into staging Nov 11, 2026
22 of 28 checks passed
cx-aniket-shinde added a commit that referenced this pull request Nov 12, 2026
* Honour the VS Code Checkmarx Self-Healing setting in Copilot agent hooks (AST-180812) (#1603)

* AST-180812 - Detect VS Code Copilot CLI sessions from GITHUB_COPILOT_INTEGRATION_ID (#1604)

* Feature/ast 180812 vscode copilot cli host (#1607)

* Update brotli dependency to v1.2.7 (AST-189161) (#1610)

* Update github.com/andybalholm/brotli from v1.2.0 to v1.2.7 (AST-189161)

Indirect dependency pulled in via anchore/syft -> anchore/archiver.
No API removals; archiver only uses NewWriterLevel/NewReader, which are unchanged.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Update Docker base image checkmarx/bash:5.3 to latest digest (AST-189161)

Bumps the SHA256-pinned base image to the 5.3-r14 build pushed on 2026-11-04.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Replace .trivyignore entries with current binary findings (AST-189161)

Ignore GO-2026-5932 (x/crypto/openpgp via helm provenance), CVE-2026-78661 and
CVE-2026-97045 (x/net/html via syft Maven cataloger). Remove the previous Wolfi
base-image and syft/docker entries, which no longer apply.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Restore syft and docker entries in .trivyignore (AST-189161)

CVE-2026-33481 (syft temp cleanup) and CVE-2026-33997 (moby plugin privilege
bypass) are still reported against the binary. Neither has an adoptable fix:
syft >= 1.42.3 reintroduces the binary-size regression reverted in AST-188320
and docker/docker has no 29.x release on its module path. Justifications and
reachability analysis are recorded in the file.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Bump golang.org/x/net to v0.62.0 and trim .trivyignore (AST-189161)

Bump the indirect golang.org/x/net dependency to v0.62.0, which fixes
CVE-2026-78661 and CVE-2026-97045, so their ignore entries are dropped.
Keep only the ignores that cannot be fixed directly: GO-2026-5932
(x/crypto openpgp, via helm), CVE-2026-33481 (syft) and CVE-2026-33997
(docker).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Co-authored-by: atishj99 <atish.jadhav@checkmarx.com>

* revret exclude git config changes (#1609)

Co-authored-by: Aniket Shinde <aniket.shinde@checkmarx.com>

* Use self-repository syntax for reusable workflow in nightly-parallel (AST-189161)

Replace `uses: ./.github/workflows/ci-tests.yml` with the `$/` form to
satisfy the zizmor `self-repository` audit (added in zizmor v1.30.0).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Handle missing feature flags(AST-188568) (#1613)

* Handle missing feature flags gracefully (code 100 response)

When the API returns a 404 with error code 100 and message
"flag with the given name is not found", return a disabled flag
model instead of nil to prevent nil pointer dereference panics
in calling code. Missing flags are treated as enabled (default)
to ensure safe feature flag fallback behavior.

Fixes panic: runtime error: invalid memory address or nil pointer dereference
when GetSpecificFlag is called and the flag doesn't exist on the server.

* Refactor: use existing WebError struct instead of inline type

Replace inline error response struct with the existing WebError struct
from ast.go for consistency with the rest of the codebase. This improves
maintainability and follows the established pattern in wrappers like
bfl-http.go and codebashing-http.go.

* handle remove ff

* Remove INCREASE_FILE_UPLOAD_LIMIT flag - now always enabled for large files

Removed the INCREASE_FILE_UPLOAD_LIMIT feature flag that controlled multipart
uploads. The flag is now permanently enabled - files > 5GB always use multipart
upload, smaller files use single upload. This simplifies the code by removing
the flag check and associated tests.

Changes:
- Removed flag constant from feature-flags.go
- Updated scan.go to always check file size (no flag check)
- Consolidated 5 tests to 3 tests (removed redundant flag-based tests)
- Behavior unchanged: multipart for >5GB, single for <=5GB

No regression - functionality preserved, code simplified.

* removed status code handling

* updated docker image

---------

Co-authored-by: Anurag Dalke <120229307+cx-anurag-dalke@users.noreply.github.com>

* Undo merge conflict resolution commit

This removes the problematic merge commit a1df4b1 that resolved
the Dockerfile conflict. Going back to the clean state before
that merge attempt.

All code is preserved - reverting to e3250aa state.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

* Ignore glibc CVE-2026-84243 and Go stdlib CVE-2026-97054 in Trivy

Both are newly disclosed. glibc comes from the checkmarx/bash base image
(fix in 2.44-r16, no rebuilt image yet); stdlib is fixed in Go 1.26.11.
Remove once the base image is rebuilt and the Go toolchain is bumped.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Rahul Pidde <206018639+cx-rahul-pidde@users.noreply.github.com>
Co-authored-by: Anurag Dalke <anurag.dalke@checkmarx.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Co-authored-by: atishj99 <atish.jadhav@checkmarx.com>
Co-authored-by: Aniket Shinde <aniket.shinde@checkmarx.com>
Co-authored-by: Anurag Dalke <120229307+cx-anurag-dalke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants