Repository navigation
fix(collector): prioritize SQLite MCP failures before log budgets - #37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
The Codex runtime SQLite query already loads at most 200 matching rows, but collection stopped after 30 admitted entries. Thirty newer normal notices could therefore hide an older readable failure inside that same bounded result, before the failure-priority selector ran.
Process the existing bounded candidates before applying the existing failure-priority output selector in both shipped helpers. Keep the 30-record / 128 KiB complete-message output budget, source/thread/content-echo filters, redaction and original-attempt uncertainty. Report the SQLite source limit only when the 200-row query bound is reached; output omissions remain reported by the shared selector.
Validation
?, which cannot be created on Windows.003c0eaf93cf1ed3f5de45bc360774ce0caf4c5a: 132/136 Windows full-suite checks passed; its existing CRLF fix removes that baseline failure, leaving only the four media filename fixtures. All 94 existing collection checks and all 18 new regressions pass in this composition.80e4a96a8f8d7f304aad76155777aba8c8fe7358; all CodeQL checks passed.Release scope
Three files only: the two helper mirrors and the regression file. No package/version bump, backend deployment, Desktop change, host configuration change or Doctor work. PR #35 remains unchanged; this fix can ship in the same final collector batch after normal review/merge. Controlled validation is not evidence of natural adoption, original-user recovery or final Axiom storage. No production diagnostic report was posted during this development validation.