Repository navigation
Conversation
imgoose
marked this pull request as ready for review
October 27, 2026 16:58
imgoose
marked this pull request as draft
October 27, 2026 17:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hosted Codex onboarding currently tells users to open another chat when tools remain absent after sign-in, and treats project-access errors as a reason to repeat OAuth. The reported incident later succeeded in its original chat, so those unconditional instructions can mislead the user.
This change checks current tool discovery and performs an actual read-only list_projects call before saying the conversation works. Empty project lists count as a successful connection. If tools remain unavailable, it allows one refresh/reconnect action actually supported by that host, then offers a new chat only as a fallback carrying the original task/project context. Project permissions and browser-cookie sign-in remain separate from MCP authentication.
Scope: one Codex Skill file. No OAuth, host-runtime, backend, collector-runtime, version, or Claude changes. The customer's recovery preceded this candidate and is not attributed to it.
Dependency: stacked on #29 and targeting its collection-integration branch, so this review contains only the onboarding change. Merge this bounded change into the #29 branch before publishing that integration to main/the store. This PR itself does not publish either channel.
Validation for8018d59a660b8c9e565b1c8567181a925009c21b:
Boundaries: these are real model actions against read-only loopback fixtures, not a new production OAuth/Web login test or a trigger-rate estimate. The original user's0.154.0 GUI and actual same-thread automatic tool-loading mechanism were not tested. There was no forced Skill-body injection, copied credential, new login, user configuration change, global install or production ChatCut call. Test thread execution used the existing permitted mode after requirements checks; no OS/UAC settings changed. Failed test-harness preparation attempts are retained separately and excluded from passing scenario evidence. Doctor remains on hold.