Add CPPWG_DEFAULT_LOGFILE - #122
Merged
Merged
Conversation
The default --logfile value was a bare "cppwg.log" literal in the argparse
setup. Move it to constants.py (as f"{CPPWG_EXT}.log") alongside the other
filename constants like CPPWG_HEADER_COLLECTION_FILENAME, and reference it as
the argument's const, so the name lives in one place.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #122 +/- ##
========================================
Coverage 99.73% 99.73%
========================================
Files 29 29
Lines 2256 2258 +2
Branches 490 490
========================================
+ Hits 2250 2252 +2
Misses 5 5
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the default --logfile value, currently a bare "cppwg.log" literal, to constants.py alongside the other filename settings like CPPWG_HEADER_COLLECTION_FILENAME, so the name lives in one place.