Fix duplicate experiment row after first experiment creation#3174
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adjusts how totalExperiments is derived during single-experiment load/upsert actions to better distinguish “unknown total” from “confirmed empty list”, and updates the inline reducer comment accordingly.
Changes:
- Updates reducer logic to use nullish-coalescing for
totalExperimentsinstead of a truthy check. - Clarifies the intent in comments, including preserving
0as a meaningful value.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bcb37
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3172
After creating the first experiment and navigating back to the Experiments page, the same experiment could appear twice until refresh.
This happened because the store treated
totalExperiments = 0as if the total count was unknown. When the detail page loaded the newly created experiment, the reducer changedtotalExperimentsfrom0to1, which allowed the root page pagination logic to fetch and append the first page again.This change preserves
0as a valid loaded total count and only falls back to1when the total count is actually unknown (nullorundefined). That keeps direct detail loading behavior intact while preventing the extra pagination fetch that caused the duplicate row.