CardState: move IntrinsicSpell into LandTraitChanges

[Hanmac]

Part of #11409

kinda cleanup before Cache are added

i try to make each of them "before changes" - "changes" - "after rules" more uniform
See this comment: #11409 (comment)

[tool4ever]

feels like the logic flow gets a bit harder to follow now 🤔

can't we do something a bit more radical and try to avoid all rulesHost stuff:
just have getReplacementList() add them on demand?

a bit like getHiddenStaticAbilities() but the big bonus is we might be able to reuse a single instance of adventureRep/omen... for the whole game 🏎️
(because all of them can just use ReplacedCard instead of Self)

[Hanmac]

feels like the logic flow gets a bit harder to follow now 🤔

can't we do something a bit more radical and try to avoid all rulesHost stuff: just have getReplacementList() add them on demand?

a bit like getHiddenStaticAbilities() but the big bonus is we might be able to reuse a single instance of adventureRep/omen... for the whole game 🏎️ (because all of them can just use ReplacedCard instead of Self)

Maybe for later MRs.

The Counter Based ones are still excluded by the rulesHost check:

forge/forge-game/src/main/java/forge/game/card/Card.java

Lines 7063 to 7073 in 1dfbcc8

	public void updateReplacementEffects(List<ReplacementEffect> list, CardState state, boolean rulesHost) {
	for (final ICardTraitChanges ck : getChangedCardTraitsList(state)) {
	ck.applyReplacementEffect(list);
	}
	// Keywords are already sorted by Layer
	getUnhiddenKeywords(state).applyReplacementEffect(list);
	if (!rulesHost) {
	return;
	}

i also wanted to move these special ones:

forge/forge-game/src/main/java/forge/game/card/Card.java

Lines 3467 to 3478 in 1dfbcc8

	if (isInPlay()) {
	if (isFaceDown() && state.getStateName() == CardStateName.FaceDown) {
	for (SpellAbility sa : getState(CardStateName.Original).getNonManaAbilities()) {
	if (sa.isTurnFaceUp()) {
	list.add(sa);
	}
	}
	}
	} else if (hasState(CardStateName.Secondary) && state.getStateName() == CardStateName.Original) {
	// Adventure and Omen may only be cast not from Battlefield
	list.addAll(getState(CardStateName.Secondary).getSpellAbilities());
	}

into getAllPossibleAbilities, there:

forge/forge-game/src/main/java/forge/game/card/Card.java

Lines 7472 to 7480 in 1dfbcc8

	if (isInPlay() && isFaceDown() && oState.getType().isCreature() && oState.getManaCost() != null && !oState.getManaCost().isNoCost())
	{
	if (isManifested()) {
	abilities.add(oState.getManifestUp());
	}
	if (isCloaked()) {
	abilities.add(oState.getCloakUp());
	}
	}

so we don't need to exclude them anymore when checking for hasNoAbilities:

forge/forge-game/src/main/java/forge/game/card/Card.java

Lines 3443 to 3449 in 1dfbcc8

	if (sa.isMorphUp() || sa.isDisguiseUp()) {
	continue;
	}
	// while Adventure and Omen are part of Secondary
	if ((sa.isAdventure() || sa.isOmen()) && !getCurrentStateName().equals(sa.getCardStateName())) {
	continue;
	}

but then the Tests does fail, because it can't find them anymore:

forge/forge-gui-desktop/src/test/java/forge/ai/simulation/GameSimulationTest.java

Lines 202 to 204 in 44a5826

	SpellAbility unmorphSA = findSAWithPrefix(ripper, "Morph — Reveal a black card");
	AssertJUnit.assertNotNull(unmorphSA);
	sim.simulateSpellAbility(unmorphSA);