Skip to content

Add plain-text card art language index and language-aware unique card selection - #11572

Closed
churrufli wants to merge 4 commits into
Card-Forge:masterfrom
churrufli:card-art-language-exceptions
Closed

Add plain-text card art language index and language-aware unique card selection#11572
churrufli wants to merge 4 commits into
Card-Forge:masterfrom
churrufli:card-art-language-exceptions

Conversation

@churrufli

@churrufli churrufli commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

This replaces the approach from #11507 and follows up on the discussion started in #11560.
Instead of a generated bitmask index, this stores confirmed non-English printings in a plain text file (forge-gui/res/languages/card-art-languages.txt, one SET/CN=lang,lang line per printing), generated by forge-gui/tools/updateCardArtLanguages.py. No bitmask, no changes to edition files,

  • New Preferences options: "Card Image Language" and "Prefer My Language for Unique Cards" (off by default, zero behavior change unless the user opts in).
  • ImageFetcher / GuiDownloadFilteredCardImages try the preferred language first when confirmed, falling back to today's default otherwise.
  • Same as the card name translation files (res/languages/cardnames-*.txt), this new file will need to be kept up to date over time. I'm happy to integrate its generation into whatever process/script this project already uses to update those. Either way, the result is plain text and editable by hand if needed.

One personal note to close: some time ago I helped with Forge's internationalization, (in the cardforge.org git) among other things. I still believe that opening the door to more languages is always a good thing for this project. I hope this gets some consideration, thank you all.

@churrufli
churrufli force-pushed the card-art-language-exceptions branch from 44b73fd to 1eab076 Compare August 9, 2026 23:37
@churrufli
churrufli force-pushed the card-art-language-exceptions branch from 1eab076 to c6c0d4f Compare August 10, 2026 00:08
@tool4ever
tool4ever requested a review from tehdiplomat August 10, 2026 14:34
@churrufli

Copy link
Copy Markdown
Contributor Author

Closing this in favor of #10928 — it already covers the language-availability data I was trying to build, and I'd rather not maintain a parallel system. I'll follow that PR and revisit the preferred-language setting and language-aware unique cards once it lands.

@churrufli churrufli closed this Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants