Repository navigation
Runner pool: claim lease tuning + node runbook (#32) - #124
Merged
Merged
Conversation
- watch --claim-lease-ms / HEADLESSCODE_CLAIM_LEASE_MS wired to claimLeaseMs (validated 30s..15m, matching claims.ts bounds) - docs/runner-pool-node.md: node install, per-machine capacity cap, claim discipline, stale-claim recovery; linked from phase5 doc
4 tasks
w4ffl35
commented
Oct 12, 2026
w4ffl35
left a comment
w4ffl35
left a comment
Member
Author
There was a problem hiding this comment.
Operator verification (the harness reviewer misfired with 'no real changes', so this substitutes for review+QA):
- Read the full diff: CLI flag + env + range validation + config wiring follow the file's existing patterns; 30000..900000 matches CLAIM_TTL_MIN/MAX_MS in claims.ts, and the poll<=half-lease constraint is enforced in watch.ts, so the help text is accurate. Runbook is concrete (install, per-machine creds, systemd, capacity, claim discipline, stale-claim recovery).
- On the PR head: npx tsc --noEmit clean; watcher suites pass (6 files).
- One correction to the PR body: muse-executor.test.ts passes on main (12/12), so its failure in the worker run looks like a worktree-environment flake, not a pre-existing failure.
Not merging here; left for maintainer review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32 (claim-based balancing path).
Claim-based balancing itself was already implemented in-tree (#32 commits 7a18bc8, 67c0fbf, 1808667, 46cf165, 68cd7c0b — all ancestors of HEAD): GitHub-ref CAS claims (src/watcher/claims.ts), pool-mode sweep/capacity/reconciliation (src/watcher/watch.ts), --runner-id/--runner-assignee CLI + lock (src/watcher/cli.ts), and pool docs (docs/phase5-issue-watcher.md). This PR closes the remaining gaps:
Verification: npx tsc --noEmit clean; all watcher suites + routing suite pass (muse-executor.test.ts fails identically on clean main — pre-existing, unrelated).