Repository navigation
Exclude database details from RSI locks and stabilize benchmark test cleanup - #118
Merged
Merged
Conversation
w4ffl35
marked this pull request as ready for review
October 12, 2026 16:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operational monitor locks now save only process identity and queue/campaign scope. Previously, spreading the runtime options into both lock serializers could include database connection details. Regression coverage inspects both lock files during real writes with credential sentinels in the pool and extra options.
The benchmark test's throwaway Git clones now use owned scratch directories, disable automatic Git maintenance, and retry transient
ENOTEMPTYcleanup failures within a fixed bound. This addresses the fixture cleanup failure that prevented the v1.9.7 release package from being published. Persistent failures and unowned-path removal still fail. The package version is prepared for v1.9.8.Closes #116. Closes #117.
Validation: typecheck and all 248 local test files passed with PostgreSQL and object storage enabled, with zero reported TAP skips. The CLI/HTTP mock checks passed 9/9. Both exact-head GitHub runs passed all 248 files and 9/9 mock checks; each hosted run skipped 40 optional database checks. Actual PostgreSQL fault checks passed for monitor recovery, stale-heartbeat detection, bounded restarts, and unchanged campaign budgets during recovery.
Earlier local attempts failed because their scratch paths exceeded Unix-socket limits. Those logs are preserved; the final run used a shorter isolated checkout without changing the source. Qualification used no local inference or GPU testing.