Skip to content

test(verify): keep the cursor out of the recording export check - #4442

Draft
richiemcilroy wants to merge 1 commit into
mainfrom
fix/verify-export-check-cursor
Draft

richiemcilroy wants to merge 1 commit into
mainfrom
fix/verify-export-check-cursor

Conversation

@richiemcilroy

@richiemcilroy richiemcilroy commented Nov 21, 2026 •

Copy link
Copy Markdown
Member

check_export (crates/verify/tests/recording.rs:4404) re-exports each finished Studio recording and reads a screen marker from every frame to find pictures the export lost. The recording keeps the real pointer, which on the Windows runners rests at the screen centre, on top of the marker. When the exported cursor is big enough to cover it (the Windows|AppStarting busy cursor, 25x29, or a larger cursor size), those frames cannot be read and the case fails export-missing although the export is correct.

let mut config = ProjectConfiguration::load(&rec.project).unwrap_or_default();
config.cursor.hide = true;
  • The check now exports without the cursor, so it measures only what it claims to: screen pictures and microphone markers.
  • Cursor rendering keeps its own coverage (crates/rendering/tests/cursor_texture_edges.rs, the rendering crate's cursor tests).
  • The diff is identical to the same change inside improve: revamp desktop styles and motion #4387, so that branch merges cleanly over it.
Recording (Windows, kept from CI) Cursor drawn Cursor hidden
studio-screen/gated, size 127 cursor at the centre 58 of 147 pictures unreadable 0
studio-screen/mp4-holds, main nightly, busy cursor at the centre 209 of 460 unreadable 0

RetriggerView in GreptileConfidence Score: 5/5

This test-only change appears safe to merge.

Summary

check_export now hides the cursor so it cannot cover the screen markers used to check exported frames.

  • The recording check exports video without drawing the cursor.

Reviews (1) · Last reviewed commit: "test(verify): keep the cursor out of the..." · Reviewed by Greptile

@vercel

vercel Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
cap-status Ignored Ignored Nov 21, 2026 4:42am UTC

@richiemcilroy

Copy link
Copy Markdown
Member Author

@greptileai review

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant