Repository navigation
test(verify): keep the cursor out of the recording export check - #4442
Draft
richiemcilroy wants to merge 1 commit into
Draft
richiemcilroy wants to merge 1 commit into
richiemcilroy wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Member
Author
|
@greptileai review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_export(crates/verify/tests/recording.rs:4404) re-exports each finished Studio recording and reads a screen marker from every frame to find pictures the export lost. The recording keeps the real pointer, which on the Windows runners rests at the screen centre, on top of the marker. When the exported cursor is big enough to cover it (theWindows|AppStartingbusy cursor, 25x29, or a larger cursor size), those frames cannot be read and the case failsexport-missingalthough the export is correct.crates/rendering/tests/cursor_texture_edges.rs, the rendering crate's cursor tests).studio-screen/gated, size 127 cursor at the centrestudio-screen/mp4-holds, main nightly, busy cursor at the centre

Confidence Score: 5/5
This test-only change appears safe to merge.Summary
check_exportnow hides the cursor so it cannot cover the screen markers used to check exported frames.Reviews (1) · Last reviewed commit: "test(verify): keep the cursor out of the..." · Reviewed by Greptile