fix(render-farm): stop padding published exports and holding opening frames - #2393
Merged
Merged
Conversation
Member
Author
|
hey @greptileai, please re-review the PR |
…de the stash part
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two render farm output fixes.
Opening frames held. With decoder readahead on, the readahead window filled the decoder's frame cache before the renderer's first request, the overflow cleared the frames it was about to ask for, and those requests fell back to frame 0. The first chunk of a clip then showed the recording's opening frame for a few seconds while the cursor and zoom kept moving. Workers now leave readahead off by default (
CAP_DECODER_READAHEAD=0), which renders the same output on every run.Zero-padded exports. Every non-final chunk was padded up to S3's 5 MiB minimum part size, so short exports split across many chunks were published mostly as zero bytes (a 9 s take came out at 47 MB for 2 MB of video). Each chunk now stashes its opening bytes in the farm bucket and uploads the rest as full-size parts. The coordinator joins the MP4 header and small stashes into valid parts and copies large stashes server side, so the published file is exactly
ftyp+moov+mdat. Journals from the old part layout are aborted on restart rather than resumed.Verification
The PR appears safe to merge based on this re-review.
Summary
The PR removes padding from published MP4 exports by stitching chunk stashes into multipart uploads, and disables decoder readahead by default. Since the previous review, it has added failure tracking so a failed stash upload cannot be reported as a successful chunk, with a regression test for that case.
Reviews (9) · Last reviewed commit: "fix(render-farm): fail a chunk whose sta..."