fix(editor): allow muting split segments independently - #2110
Open
akash1520 wants to merge 1 commit into
Open
Conversation
akash1520
force-pushed
the
fix/independent-segment-mute
branch
from
August 11, 2026 08:13
bd66fc6 to
7a0de47
Compare
Member
|
hey! can you please get this to a 5/5? |
Persist mute state per timeline segment instead of per clip, so splitting a segment lets each half be muted independently. Centralizes the mute check in the audio renderer for normal-speed, retimed, and transition audio, and threads audioMuted through Cap-project import so it isn't lost when appending a muted segment into another project.
akash1520
force-pushed
the
fix/independent-segment-mute
branch
from
August 11, 2026 13:46
7a0de47 to
71a1a26
Compare
Author
|
Hey @richiemcilroy, could you re-run Greptile on this? I've fixed the import regression it flagged and added a test covering it, so it should score 5/5 now. |
Member
|
hey @greptileai please re-review the pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2109.
Adds segment-level audio muting for recording clips. After splitting a clip, each resulting segment can now be muted or unmuted independently from the editor sidebar.
Changes
audioMutedproperty to timeline segmentsTesting
cargo test -p cap-editor audio::testscargo test -p cap-project timeline_segment_defaults_audio_muted_for_existing_projectscargo check -p cap --all-targetscargo check -p cap-desktopUI after this PR
Greptile Summary
The PR adds independently persisted segment-level audio muting and applies it consistently during preview, export, splitting, and Cap-project import.
audioMutedtimeline-segment field with backward-compatible deserialization.Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains; the previously reported import path now preserves each timeline segment’s mute state through the target timeline construction.
Important Files Changed
audio_mutedvalue into the imported timeline, resolving the prior reset.Reviews (2): Last reviewed commit: "fix(editor): allow muting split segments..." | Re-trigger Greptile
Context used (3)